pallet-revive: Fix the contract size related benchmarks #7568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All GitHub workflows were cancelled due to failure one of the required jobs. |
|
/cmd fmt --clean |
pgherveou
approved these changes
Feb 14, 2025
xermicus
approved these changes
Feb 14, 2025
Co-authored-by: PG Herveou <[email protected]>
Co-authored-by: PG Herveou <[email protected]>
smiasojed
reviewed
Feb 14, 2025
| pub fn sized(size: u32) -> Self { | ||
| // Due to variable length encoding of instructions this is not precise. But we only | ||
| // need rough numbers for our benchmarks. | ||
| Self::with_num_instructions(size / 3) |
There was a problem hiding this comment.
Could you please explain why we divide by 3? Is it a minimal instruction size?
There was a problem hiding this comment.
This is the average size of an instruction in the PolkaVM blob. But since it uses variable size encoding its not excact (see comment above). I played around a little with divisors until i get roughly the amount of instructions to hit the max blob size.
clangenb
pushed a commit
to clangenb/polkadot-sdk
that referenced
this pull request
Feb 19, 2025
) Partly addresses paritytech#6157 The benchmarks measuring the impact of contract sizes on calling or instantiating a contract were bogus because they needed to be written in assembly in order to tightly control the basic block size. This fixes the benchmarks for: - call_with_code_per_byte - upload_code - instantiate_with_code And adds a new benchmark that accounts for the fact that the interpreter will always compile whole basic blocks: - basic_block_compilation After this PR only the weight we assign to instructions need to be addressed. --------- Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: PG Herveou <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partly addresses #6157
The benchmarks measuring the impact of contract sizes on calling or instantiating a contract were bogus because they needed to be written in assembly in order to tightly control the basic block size.
This fixes the benchmarks for:
And adds a new benchmark that accounts for the fact that the interpreter will always compile whole basic blocks:
After this PR only the weight we assign to instructions need to be addressed.