Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(collator) add export pov on slot base collator #7585

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

feat(collator) add export pov on slot base collator #7585

wants to merge 6 commits into from
+118 −71

Conversation

MrishoLukamba
Copy link
Contributor

@MrishoLukamba MrishoLukamba commented Feb 16, 2025 •
edited
Loading

@MrishoLukamba
Copy link
Contributor Author

Done, all the failing checks arent related to PR @skunert @bkchr except the fmt

skunert
skunert reviewed Feb 19, 2025
View reviewed changes
@MrishoLukamba
Copy link
Contributor Author

Done, and one suggestion, I want to also refactor lookahead collators to just include the export_pov inside the Params

@skunert @bkchr

@bkchr
Copy link
Member

bkchr commented Feb 21, 2025

/cmd fmt

@bkchr bkchr added the T0-node This PR/Issue is related to the topic “node”. label Feb 22, 2025
@bkchr bkchr requested a review from skunert February 22, 2025 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkchr bkchr bkchr approved these changes

@skunert skunert Awaiting requested review from skunert

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
T0-node This PR/Issue is related to the topic “node”.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add pov-export to slot-based collator
3 participants
@MrishoLukamba @bkchr @skunert