Expose supported compilers #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xermicus
approved these changes
Jan 21, 2025
There was a problem hiding this comment.
LGTM as a temporary solution. In the long run we should have the client (remix) bundle solc.js and resolc.js together based on what the users chooses. This means we just host resolc.js (on the revive repo GH pages and possibly in IPFS). This is akin to what we do with the binaries as it prevents releasing an ever growing matrix of resolc and solc combinations.
|
Remix expects one compiler file. I needed to concat soljson and revive into one file |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The temporary solution to expose the available compilers from the backend endpoint. Finally they should be available from the Revive GH Pages.