주차장 상세조회 #56
Merged
주차장 상세조회 #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results129 tests 129 ✅ 3s ⏱️ Results for commit 29b0092. ♻️ This comment has been updated with latest results. |
jundonghyuk
approved these changes
Mar 28, 2024
jundonghyuk
approved these changes
Mar 28, 2024
Comment on lines
+43
to
+51
| void 주차장_상세조회() { | ||
| //given | ||
| String parkingName = "호이주차장"; | ||
| Parking parking = makeParking(parkingName); | ||
| List<Parking> parkings = List.of(parking); | ||
| parkingService.saveAll(parkings); | ||
|
|
||
| Member member = new Member("하디", "email", "동혁", new Password("qwer1234")); | ||
| memberRepository.save(member); |
There was a problem hiding this comment.
@MethodSource로 인자로 받아도 될것같아용
This2sho
reviewed
Apr 1, 2024
| private Integer lastUpdated; | ||
| private String tel; | ||
| private String paymentType; | ||
| private ReviewInfoResponse reviewInfo; |
There was a problem hiding this comment.
api 스펙에 없어서 놓쳤네여 추가햇슴다
| import org.springframework.web.bind.annotation.PathVariable; | ||
| import org.springframework.web.bind.annotation.RestController; | ||
|
|
||
| @RequiredArgsConstructor |
| @@ -23,4 +29,32 @@ public void saveAll(List<Parking> parkingLots) { | |||
| public Set<Parking> getParkingLots(Set<String> parkingNames) { | |||
| return parkingRepository.findAllByBaseInformationNameIn(parkingNames); | |||
| } | |||
|
|
|||
| @Transactional(readOnly = true) | |||
| public ParkingDetailInfoResponse findParking(Long parkingId, LocalDateTime now) { | |||
There was a problem hiding this comment.
LocalDateTime now를 인자로 받는 이유가 있나여?
There was a problem hiding this comment.
최대한 요청한 시각과 가까운 곳이 service 보단 controller 라고 생각해서 controller 에서 생성해서 넘겨줬습니다. 도메인에서 쓰는게 더 나아보이시나요?
사실 오차가 존재해도 무방한 기능이라 고민하긴 했어여
# Conflicts: # src/main/java/com/example/parking/api/parking/ParkingController.java # src/main/java/com/example/parking/application/parking/ParkingService.java # src/main/java/com/example/parking/domain/parking/Parking.java # src/test/java/com/example/parking/fake/FakeParkingService.java
This2sho
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👍관련 이슈
🤔세부 내용
🫵리뷰 중점사항
마지막 업데이트가 몇 분 전인지 구하는 로직 테스트
상세조회에서 단순 조회 말고 로직이 있는건 마지막 업데이트가 몇 분 전에 이뤄졌는지 구하는 기능입니다. 그런데, updatedAt 값이 JpaAuditing 에 의해서만 만들어져서 테스트가 어렵습니다.
그래서 JpaAuditing 에 (createdAt, updatedAt) 생성자를 생성하려 했는데 이렇게 하니 모든 도메인의 생성자에 (createdAt, updatedAt) 을 받는 생성자를 추가해서 여러분 의견을 반영해서 어떻게 할지 정하는게 맞는것같아서 일단 해당 테스트는 진행하지 못했습니다.