-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
True #174
Open
Udaara
wants to merge
257
commits into
feature/add_benchmark
Choose a base branch
from
master
base: feature/add_benchmark
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
True #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Typo: Pritnln -> Println
leading to leaking memory/sockets
also added tests and refactored relevant tests.
…mode. Add Debug and logger to the `SuperAgent` struct, enables logs to request/response. - Add `SetDebug` to enable/disable debug mode - Add `SetLogger` to enable 3rd integrator leverage his own logger In debug mode, leverage httputil to dump details of every request/response.
- Let editor can auto completion the types. e.g. vim-go. - Add test cases for make sure they are correct.
Fix typo in doc
Change SuperAgent.Header type to http.Header for support multiple values
Add option to prevent SuperAgent from clearing
Add type constants
Allow the superagent to be cloned so it can be reused. This allows you to set basic settings once (eg webserver startup), and then reuse the superagent. Remove old "Timeout" method, and use the http.Client.Timeout instead. "Safely" clone modifications the http.Client & Transport on a Clone if we can.
Added doc for DoNotClearSuperAgent
Add references to the issue being addressed and better comments and variablenames.
Don't infer Content-Type when set explicitly
updating some of the English
Handle error in byte stream (failed transfer of a chunk)
"Clone" the SuperAgent for reuse
chore: bump moul.io/http2curl dependency
Add possibility to use fieldname file (not change it to file1, file2,…
add context support
Fix wrong example
Update Master to catch up with Dev branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.