fix: run fields_mismatch against static_schema data also (#1123)

parseablehq · Jan 23, 2025 · 5286782 · 5286782
1 parent 02e2007
commit 5286782
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 5 deletions.
diff --git a/src/event/format/json.rs b/src/event/format/json.rs
@@ -44,7 +44,6 @@ impl EventFormat for Event {
     fn to_data(
         self,
         schema: &HashMap<String, Arc<Field>>,
-        static_schema_flag: bool,
         time_partition: Option<&String>,
         schema_version: SchemaVersion,
     ) -> Result<(Self::Data, Vec<Arc<Field>>, bool), anyhow::Error> {
@@ -94,8 +93,7 @@ impl EventFormat for Event {
             }
         };
 
-        if !static_schema_flag
-            && value_arr
+        if value_arr
                 .iter()
                 .any(|value| fields_mismatch(&schema, value, schema_version))
         {

diff --git a/src/event/format/mod.rs b/src/event/format/mod.rs
@@ -99,7 +99,6 @@ pub trait EventFormat: Sized {
     fn to_data(
         self,
         schema: &HashMap<String, Arc<Field>>,
-        static_schema_flag: bool,
         time_partition: Option<&String>,
         schema_version: SchemaVersion,
     ) -> Result<(Self::Data, EventSchema, bool), AnyError>;
@@ -115,7 +114,6 @@ pub trait EventFormat: Sized {
     ) -> Result<(RecordBatch, bool), AnyError> {
         let (data, mut schema, is_first) = self.to_data(
             storage_schema,
-            static_schema_flag,
             time_partition,
             schema_version,
         )?;