-
-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test + refactor: staging #1129
test + refactor: staging #1129
Conversation
Pull Request Test Coverage Report for Build 13032630803Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Only failure is because of alerts check, which will continue to fail until #1101 is merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #XXXX.
Description
While trying to audit the code to perform staging, I made these improvements that reduces unnecessary copies and added tests to critical parts of the flow and hence improve coverage.
This PR has: