Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: only compare names #1141

Merged
merged 8 commits into from
Jan 31, 2025
Merged

refactor: only compare names #1141

merged 8 commits into from
Jan 31, 2025

Conversation

de-sh
Copy link
Contributor

@de-sh de-sh commented Jan 29, 2025

Fixes #XXXX.

Description

We are unnecessarily complicating the existence check, this can be simplified using a HashSet as done in the PR.


This PR has:

  • been tested to ensure log ingestion and log query works.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

@coveralls
Copy link

coveralls commented Jan 29, 2025

Pull Request Test Coverage Report for Build 13028279147

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 26 (0.0%) changed or added relevant lines in 7 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.01%) to 12.965%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/handlers/http/logstream.rs 0 1 0.0%
src/handlers/http/modal/utils/logstream_utils.rs 0 1 0.0%
src/handlers/http/query.rs 0 1 0.0%
src/migration/mod.rs 0 3 0.0%
src/storage/localfs.rs 0 4 0.0%
src/storage/azure_blob.rs 0 8 0.0%
src/storage/s3.rs 0 8 0.0%
Files with Coverage Reduction New Missed Lines %
src/storage/azure_blob.rs 2 0.0%
src/storage/s3.rs 2 0.0%
Totals Coverage Status
Change from base Build 13025432081: 0.01%
Covered Lines: 2477
Relevant Lines: 19106

💛 - Coveralls

Copy link
Contributor

@nikhilsinhaparseable nikhilsinhaparseable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@nitisht nitisht merged commit 68e12b2 into parseablehq:main Jan 31, 2025
11 checks passed
@de-sh de-sh deleted the all branch January 31, 2025 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants