[Feature] Finite shots #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atiyo
reviewed
Jul 12, 2024
|
Adds finite shot sampling of expectations to horqrux. GPSR will be added in a future MR. |
atiyo
reviewed
Jul 25, 2024
atiyo
reviewed
Jul 25, 2024
jpmoutinho
approved these changes
Jul 26, 2024
There was a problem hiding this comment.
Thanks @atiyo !
I am not too familiar with horqrux yet, but feel free to ping me if you want to discuss anything.
I think Dominik made very similar design choices between horqrux and pyqtorch, and we have been making some improvements to pyqtorch recently, so it may be worth porting some of those to horqrux as well.
gvelikova
approved these changes
Jul 26, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.