Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remake #9

Merged
merged 26 commits into from
Jan 25, 2024
Merged

Remake #9

merged 26 commits into from
Jan 25, 2024

Conversation

dominikandreasseitz
Copy link
Collaborator

@dominikandreasseitz dominikandreasseitz commented Jan 22, 2024

Full remake of horqrux inspired by pyqtorch

Copy link
Collaborator

@jpmoutinho jpmoutinho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dominikandreasseitz! Not much to say :)

Like I mentioned in the meeting I do feel like having the (more standard) control operations explicitly defined would be a bit cleaner even if requiring a few extra lines of code. From the QC user perspective I think it is clearer to immediately read CNOT(0, 1) than it is NOT(0, 1), and also being able to access the full unitary could be useful.

But either way I personally don't mind this since I would use this through Qadence so feel free to leave that for later in case future users suggest it.

horqrux/utils.py Outdated Show resolved Hide resolved
tests/test_gates.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@RolandMacDoland RolandMacDoland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very lean and lovely work. Thanks @dominikandreasseitz. Not much to say about it. Some cosmetic comments and few for the sake of discussion. Two main points: I would avoid the ambiguous empty dict constructor {} in favour of dict() and update the docstrings.

horqrux/abstract.py Show resolved Hide resolved
horqrux/abstract.py Outdated Show resolved Hide resolved
horqrux/abstract.py Outdated Show resolved Hide resolved
horqrux/apply.py Outdated Show resolved Hide resolved
horqrux/apply.py Show resolved Hide resolved
horqrux/primitive.py Outdated Show resolved Hide resolved
horqrux/primitive.py Outdated Show resolved Hide resolved
horqrux/utils.py Show resolved Hide resolved
horqrux/utils.py Outdated Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
@dominikandreasseitz dominikandreasseitz merged commit d54c02d into main Jan 25, 2024
5 checks passed
@dominikandreasseitz dominikandreasseitz deleted the ds/remake branch January 25, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants