-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remake #9
Remake #9
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dominikandreasseitz! Not much to say :)
Like I mentioned in the meeting I do feel like having the (more standard) control operations explicitly defined would be a bit cleaner even if requiring a few extra lines of code. From the QC user perspective I think it is clearer to immediately read CNOT(0, 1) than it is NOT(0, 1), and also being able to access the full unitary could be useful.
But either way I personally don't mind this since I would use this through Qadence so feel free to leave that for later in case future users suggest it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very lean and lovely work. Thanks @dominikandreasseitz. Not much to say about it. Some cosmetic comments and few for the sake of discussion. Two main points: I would avoid the ambiguous empty dict constructor {}
in favour of dict()
and update the docstrings.
Full remake of horqrux inspired by pyqtorch