[Feature] Create a IRBuilder and ir_compiler_factory #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
There was a problem hiding this comment.
Thanks a lot @kaosmicadei. Some (hopefully useful) comments from me.
kaosmicadei
changed the title
There was a problem hiding this comment.
Awesome work @kaosmicadei, really nice. Minor cosmetic comments. I would pay attention to docstrings and layouts in general. Also, we can move to pytest if we want to run that on the CI 😬. Will approve in following but that should be relatively quick.
Co-authored-by: Roland-djee <[email protected]>
…ons (add, sub, mul, div, rem, pow)
…patible with "crossing-lattice" strategy and `PyQ` gridless model
Doomsk
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, these helper functionalities aim to be used in the Qadence 1 syntax port. Later, they can be used to implement new input formats for Qadence 2 IR.
Closes #1