[Testing] Adding unit tests to all classes and functions in types.py #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pimvenderbosch
requested review from
RolandMacDoland,
Doomsk and
kaosmicadei
and removed request for
RolandMacDoland and
Doomsk
kaosmicadei
reviewed
Nov 1, 2024
kaosmicadei
reviewed
Nov 1, 2024
RolandMacDoland
changed the title
kaosmicadei
reviewed
Nov 1, 2024
Doomsk
reviewed
Nov 4, 2024
pimvenderbosch
changed the title
|
Hi all, thanks for the initial review. I've pushed some extra tests to cover the full types.py file. I've chanced the scope of this PR to only cover tests for that file. PRs for the other files will follow. Would be nice if you could review again, so we can proceed with merging. |
Doomsk
approved these changes
Nov 6, 2024
RolandMacDoland
approved these changes
Nov 6, 2024
pimvenderbosch
added a commit
that referenced
this pull request
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently not al classes and functions are properly tested. This PR introduces unit tests to cover the full code base.