Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Let's run the notebook during tests #10

Merged
merged 12 commits into from
Jan 7, 2025
Merged

[CI] Let's run the notebook during tests #10

merged 12 commits into from
Jan 7, 2025

Conversation

Yoric
Copy link
Collaborator

@Yoric Yoric commented Dec 27, 2024 •
edited
Loading

In this PR:

  • importing the tests from another PR;
  • minor fixes to module qek.kernel;
  • a new CI job test_notebook that runs the notebook;
  • minor tweaks to pipeline.ipynb to make it faster to execute.

@Yoric Yoric force-pushed the yoric/test-notebook branch 2 times, most recently from 4180a55 to 4cf3326 Compare January 6, 2025 14:15
@Yoric Yoric requested a review from RolandMacDoland January 6, 2025 14:58
@Yoric Yoric mentioned this pull request Jan 6, 2025
Closed
RolandMacDoland
RolandMacDoland approved these changes Jan 7, 2025
View reviewed changes
Copy link
Collaborator

@RolandMacDoland RolandMacDoland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Yoric. LGTM. Minor comments.

qek/kernel/kernel.py Outdated Show resolved Hide resolved
.github/workflows/test.yml Show resolved Hide resolved
@Yoric Yoric force-pushed the yoric/test-notebook branch from 18b81cb to 499f781 Compare January 7, 2025 13:24
@Yoric Yoric merged commit 2c402db into main Jan 7, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RolandMacDoland RolandMacDoland RolandMacDoland approved these changes

Assignees

@Yoric Yoric

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Yoric @RolandMacDoland