Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGL 2.0 #37

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

kdziamura
Copy link

@kdziamura kdziamura commented Nov 17, 2018

#27

I've started from suggestion to change options interface (it was mixed with canvas context attributes options. From my point of view it’s a bit confusing but I will not insist if the changes are unacceptable) and finished with implementation of WebGL2 support.

@morisil
Copy link

morisil commented Jun 26, 2020

@wontem I would like to use your PR, but it does not work with multibuffer shaders

It's because the following invalid shader code is produced:

#define BUFFER_0
#version 300 es

#ifdef GL_ES
precision mediump float;
#endif
...

Which results in:

Error compiling shader [object WebGLShader]:ERROR: 0:2: 'version' : #version directive must occur before anything else, except for comments and white space

@kdziamura
Copy link
Author

kdziamura commented Jul 6, 2020

@kdziamura
Copy link
Author

The problem with buffers is still here. Unfortunately, haven't look into it for a long time and still have no time to work on it 😞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants