refactor(EmptyState): extract helpers, fix(EmptyState): getElementChildText fix #602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamviktora
changed the title
adamviktora
changed the title
...ods/src/rules/v6/emptyStateHeaderMoveIntoEmptyState/emptyStateHeader-move-into-emptyState.ts
Outdated
Show resolved
Hide resolved
...rc/rules/v6/emptyStateHeaderMoveIntoEmptyState/emptyStateHeader-move-into-emptyState.test.ts
Show resolved
Hide resolved
- previously the switch would unintentionally handle most cases under JSXText, as the first few whitespaces count as JSXText of children
adamviktora
force-pushed
the
empty-state-refactor-helpers
branch
from
d884252 to
5e6ff93
Compare
packages/eslint-plugin-pf-codemods/src/rules/helpers/JSXAttributes.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Dominik Petřík <[email protected]>
adamviktora
force-pushed
the
empty-state-refactor-helpers
branch
from
6ae3450 to
0ec8130
Compare
Dominik-Petrik
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #594
Also applies a fix to a function which gets children text of EmptyStateHeader.
Previously, situations like this:
were caught in switch command under
JSXText(because of the initial whitespaces before<h1>).And if not, it ended up always being wrapped in
"", which we don't want, if the children is not a singleJSXTextelement.