Skip to content

Commit

Permalink
Fix issue #72
Browse files Browse the repository at this point in the history
  • Loading branch information
paul1956 committed Feb 17, 2021
1 parent 8530c64 commit c0998a7
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 7 deletions.
4 changes: 2 additions & 2 deletions CSharpToVB.Tests/Test/CSharpToVB/ExpressionTests.vb
Original file line number Diff line number Diff line change
Expand Up @@ -560,15 +560,15 @@ End Class")
DoSomething()
End If

If s1 Is object2 Then
If s1 = object2 Then
DoSomething()
End If

If object1 = j Then
DoSomething()
End If

If object1 Is s2 Then
If object1 = s2 Then
DoSomething()
End If

Expand Down
6 changes: 3 additions & 3 deletions CodeConverter/CodeConverter.vbproj
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,9 @@
<Product>VB Core Code Converter</Product>
<RepositoryUrl>https://github.com/paul1956/CSharpToVB</RepositoryUrl>
<RepositoryType>git</RepositoryType>
<AssemblyVersion>5.0.1.8</AssemblyVersion>
<FileVersion>5.0.1.8</FileVersion>
<Version>5.0.1.8</Version>
<AssemblyVersion>5.0.1.9</AssemblyVersion>
<FileVersion>5.0.1.9</FileVersion>
<Version>5.0.1.9</Version>
<Copyright>Copyright (c) .NET Foundation and Contributors</Copyright>
<EnableNETAnalyzers>true</EnableNETAnalyzers>
<EnforceCodeStyleInBuild>true</EnforceCodeStyleInBuild>
Expand Down
2 changes: 1 addition & 1 deletion CodeConverter/Extensions/ExpressionSyntaxExtensions.vb
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,7 @@ Namespace CSharpToVBConverter
Friend Function IsReferenceComparison(Expression1 As CSS.ExpressionSyntax, Expression2 As CSS.ExpressionSyntax, Model As SemanticModel) As Boolean
Dim typeSymbol1 As (IsRefType As Boolean, IsString As Boolean) = IsReferenceTypeOrString(Expression1, Model)
Dim typeSymbol2 As (IsRefType As Boolean, IsString As Boolean) = IsReferenceTypeOrString(Expression2, Model)
Return typeSymbol1.IsRefType AndAlso typeSymbol2.IsRefType AndAlso Not (typeSymbol1.IsString AndAlso typeSymbol2.IsString)
Return typeSymbol1.IsRefType AndAlso typeSymbol2.IsRefType AndAlso Not (typeSymbol1.IsString OrElse typeSymbol2.IsString)
End Function

<Extension>
Expand Down
5 changes: 4 additions & 1 deletion ReadMe.MD
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ description: "C# to VB Converter"
- Code Converter

## Updated
- 1/21/2021
- 2/16/2021

## Description
This application will convert C# to VB while trying to preserve comments, formatting and as many Directives
Expand Down Expand Up @@ -64,6 +64,9 @@ Microsoft.Dotnet.XUnitExtensions which provides ConditionalFact and PlatformSpec
Any changes to CSharpToVB application needs to change the version information in the project file **AND** in MyProject/AssemblyInfo.vb until Visual Studio is able to general file automatically for a WinForms application.

## What's New in this release
New in 5.0.2.6/5.0.1.9
- Fix issue #72

New in 5.0.2.6/5.0.1.8
- Fix messages for issue #70

Expand Down

0 comments on commit c0998a7

Please sign in to comment.