「支払い時」「顧客カードに対する3Dセキュア」に対応 #95
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduce new method `startThreeDSecureProcess(viewController:delegate:resourceId:)` in ThreeDSecureProcessHandler - Add `makeTdsEntryUrl(resourceId:)` method to ThreeDSecureURLConfiguration - Mark previous token-based method as deprecated - Update tests to support new resource ID-based 3D Secure process
yatatsu
reviewed
Jan 29, 2025
| @@ -46,19 +51,33 @@ class ThreeDSecureProcessHandlerTests: XCTestCase { | |||
| XCTAssertEqual(mockDriver.openWebBrowserUrl?.absoluteString, token.tdsEntryUrl.absoluteString) | |||
There was a problem hiding this comment.
例えばですが、Token.tdsEntryUrl を利用している箇所は追加いただいた PAYJPSDK.threeDSecureURLConfiguration?.makeTdsEntryUrl で代替可能に見えますがどうでしょうか？
Token 側の extension を消す（ public ではないので非推奨ではなく削除する）とロジックを集約できるメリットがあると思いました。
| @@ -19,4 +19,15 @@ public class ThreeDSecureURLConfiguration: NSObject { | |||
| self.redirectURL = redirectURL | |||
| self.redirectURLKey = redirectURLKey | |||
| } | |||
|
|
|||
| public func makeTdsEntryUrl(resourceId: String) -> URL { | |||
There was a problem hiding this comment.
public な関数であれば略語より ThreeDSecure を使うとよりベターです。
makeThreeDSecureEntryURL(resouceId: String)
| public func startThreeDSecureProcess(viewController: UIViewController, | ||
| delegate: ThreeDSecureProcessHandlerDelegate, | ||
| token: Token) { | ||
| self.delegate = delegate | ||
| webDriver.openWebBrowser(host: viewController, url: token.tdsEntryUrl, delegate: self) | ||
| } | ||
|
|
||
| public func startThreeDSecureProcess(viewController: UIViewController, |
There was a problem hiding this comment.
@objc つけないとobjective-c側で呼び出せなそうですかね。
ThreeDSecureProcessHandlerDelegateにもつけないとダメそうです。
- Remove `tdsEntryUrl` method from Token model - Update ThreeDSecureProcessHandler to use new URL configuration method - Modify test to use new URL generation approach
- Rename `makeTdsEntryUrl` to `makeThreeDSecureEntryURL` in ThreeDSecureURLConfiguration - Update method calls in ThreeDSecureProcessHandler and tests - Improve method naming for better readability
laiso
force-pushed
the
laiso/3ds
branch
2 times, most recently
from
ef79211 to
319563c
Compare
- Add Objective-C compatibility annotations to ThreeDSecureProcessHandler - Update example Objective-C app to handle 3D Secure verification flow - Implement 3D Secure delegate methods in CardFormViewScrollViewController - Add pending token handling for 3D Secure verification
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
既存のstartThreeDSecureProcessメソッドはトークン作成時の3Dセキュア認証のみを受け付けており、「支払い時」「顧客カードに対する3Dセキュア」に対応できていないため以下の新しいメソッドを追加します。