Use -- for string * commands
#8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`string match`, `string escape` and friends will try to parse any
argument that starts with a `-` as a switch. If a string being
processed happens to start with a `-` it will, most likely, cause an
"unknown option" error.
Any `string cmd` that uses variables, especially those containing
externally provided values, should use `--` to indicate the end of the
`string` command switches and start of the positional parameters.
Consider:
```fish
> string match '*a*b' --axxb
string match: --axxb: unknown option
(Type 'help string' for related documentation)
> string match -- '*a*b' --axxb
--axxb
```
This is causing real errors, for example, as git aliases may start with
a switch for `git` itself, as in
```.gitconfig
[alias]
dt = --paginate difftool --tool=difft
```
|
Thanks. I was also struggling with this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
string match,string escapeand friends will try to parse any argument that starts with a-as a switch. If a string being processed happens to start with a-it will, most likely, cause an "unknown option" error.Any
string cmdthat uses variables, especially those containing externally provided values, should use--to indicate the end of thestringcommand switches and start of the positional parameters.Consider:
This is causing real errors, for example, as git aliases may start with a switch for
gititself, as in