Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update QMarkdownTextEdit::handleBracketClosing to fix #207 #208

Merged
merged 2 commits into from
Aug 4, 2024
Merged

Update QMarkdownTextEdit::handleBracketClosing to fix #207 #208

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eebf03a
Update `QMarkdownTextEdit::handleBracketClosing` to fix #207
com3dian Aug 3, 2024
dbd79a1
Update QMarkdownTextEdit::handleBracketClosing to fix #207
com3dian Aug 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion qmarkdowntextedit.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -717,7 +717,7 @@ bool QMarkdownTextEdit::handleBracketClosing(const QChar openingCharacter,
// Remove whitespace at start of string (e.g. in multilevel-lists).
const QString text = cursor.block().text().remove(QRegularExpression("^\\s+"));

const int pib = cursor.positionInBlock();
const int pib = cursor.positionInBlock() - cursor.block().text().length() + text.length();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good one.

Would suggest using extra () parens to make the addition/subtraction order clear

bool isPreviousAsterisk = pib > 0 && pib < text.length() && text.at(pib - 1) == '*';
bool isNextAsterisk = pib < text.length() && text.at(pib) == '*';
bool isMaybeBold = isPreviousAsterisk && isNextAsterisk;
Expand Down
Loading