BLD: include pcdsutils dependency #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
|
Good catch |
|
This will fail while bluesky is missing the numpy 2.0 compatibility fixes. I think we can merge this anyway, knowing the tests won't pass yet |
ZLLentz
approved these changes
Jun 20, 2024
|
Bypassing checks here. There remains work to be done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
pcdsutils is imported but not listed in the requirements
pcdsdaq/pcdsdaq/daq/lcls2.py
Line 59 in 22ad154
Motivation and Context
Found while trying to update the nabs dependencies
How Has This Been Tested?
CI hopefully
Where Has This Been Documented?
This PR