Skip to content

Commit

Permalink
ARROW-4344: [Java] Further cleanup mvn output, upgrade rat plugin
Browse files Browse the repository at this point in the history
Further cleanup of mvn output to help reduce CI log clutter. Changed EchoServer used in tests to have log level of debug. Upgraded rat license check plugin to 0.13. The previous version made lots of output just showing what file types were being excluded. The upgraded version omits this, but it can be enabled by setting --debug.

Author: Bryan Cutler <[email protected]>

Closes apache#3466 from BryanCutler/java-further-mvn-cleanup-ARROW-4344 and squashes the following commits:

65e0dce <Bryan Cutler> Change EchoServer logging level to debug for tests
b58cd03 <Bryan Cutler> Upgrade Java rat plugin to 0.13
  • Loading branch information
BryanCutler committed Jan 24, 2019
1 parent 95788ce commit 28a965e
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
2 changes: 1 addition & 1 deletion java/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -350,7 +350,7 @@
<plugin>
<groupId>org.apache.rat</groupId>
<artifactId>apache-rat-plugin</artifactId>
<version>0.11</version>
<version>0.13</version>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
Expand Down
14 changes: 7 additions & 7 deletions java/tools/src/main/java/org/apache/arrow/tools/EchoServer.java
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,9 @@ public class EchoServer {
private boolean closed = false;

public EchoServer(int port) throws IOException {
LOGGER.info("Starting echo server.");
LOGGER.debug("Starting echo server.");
serverSocket = new ServerSocket(port);
LOGGER.info("Running echo server on port: " + port());
LOGGER.debug("Running echo server on port: " + port());
}

public static void main(String[] args) throws Exception {
Expand All @@ -59,25 +59,25 @@ public int port() {
public void run() throws IOException {
try {
while (!closed) {
LOGGER.info("Waiting to accept new client connection.");
LOGGER.debug("Waiting to accept new client connection.");
Socket clientSocket = serverSocket.accept();
LOGGER.info("Accepted new client connection.");
LOGGER.debug("Accepted new client connection.");
try (ClientConnection client = new ClientConnection(clientSocket)) {
try {
client.run();
} catch (IOException e) {
LOGGER.warn("Error handling client connection.", e);
}
}
LOGGER.info("Closed connection with client");
LOGGER.debug("Closed connection with client");
}
} catch (java.net.SocketException ex) {
if (!closed) {
throw ex;
}
} finally {
serverSocket.close();
LOGGER.info("Server closed.");
LOGGER.debug("Server closed.");
}
}

Expand Down Expand Up @@ -116,7 +116,7 @@ public void run() throws IOException {
}
writer.end();
Preconditions.checkState(reader.bytesRead() == writer.bytesWritten());
LOGGER.info(String.format("Echoed %d records", echoed));
LOGGER.debug(String.format("Echoed %d records", echoed));
}
}
}
Expand Down

0 comments on commit 28a965e

Please sign in to comment.