-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improves performance and more #48
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peddybeats
approved these changes
Apr 19, 2020
cdc06bc
to
dad2966
Compare
Using `minify`
And syncs `dev` and `index` in areas where they should have been the same.
Not necessarily related to performance/LH but a necessary file nonetheless which was missing.
dad2966
to
fc30e02
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR initially started as a performance-focused improvement plan.
I also got around to improving (at least according to the local LightHouse evaluations I did) the app in a11y (accessibility), best practices, SEO and progressiveness.
There's still room for improvement in performance, best practise and in progressiveness/offline-friendliness tho, I listed some ideas at the bottom of this PR.
The LH score here (as well as the one on handsdown.dev will possibly be a bit different in terms of results) were:
Given the following format:
Performance / A11y / BestPractices / SEO / (PWA: Fast&Reliable, Installable, PWA Optimised) = AverageScore %
where all but the PWA metrics are in % and the PWA ones are respectively out of 3, 3 and 7 (this is just to simplify the results).Re #7
Some other ways to improve the performance include:
DocumentFragment
where possible.crel
.Edit: The LHCI score change is as follows:
index
@masterindex
dev
@masterdev