Skip to content

Commit

Permalink
lint rule
Browse files Browse the repository at this point in the history
  • Loading branch information
pedia committed Feb 26, 2024
1 parent d24b5e9 commit b2323ea
Show file tree
Hide file tree
Showing 7 changed files with 25 additions and 43 deletions.
22 changes: 8 additions & 14 deletions analysis_options.yaml
Original file line number Diff line number Diff line change
@@ -1,15 +1,9 @@
# Defines a default set of lint rules enforced for
# projects at Google. For details and rationale,
# see https://github.com/dart-lang/pedantic#enabled-lints.
include: package:pedantic/analysis_options.yaml
include: package:lints/recommended.yaml

# For lint rules and documentation, see http://dart-lang.github.io/linter/lints.
# Uncomment to specify additional rules.
# linter:
# rules:
# - camel_case_types

# analyzer:
# exclude:
# - example/**
# - test/**
linter:
rules:
avoid_shadowing_type_parameters: false
await_only_futures: true
use_string_in_part_of_directives: false # https://dart.dev/tools/linter-rules/use_string_in_part_of_directives
hash_and_equals: false
todo: ignore
14 changes: 0 additions & 14 deletions example/web_ex/analysis_options.yaml

This file was deleted.

10 changes: 5 additions & 5 deletions example/web_ex/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,12 @@ environment:
sdk: '>=3.0.0 <4.0.0'

dependencies:
http:
http: ^1.2.0
epubrs:
path: ../..
archive:
archive: ^3.4.10
web: ^0.4.2

dev_dependencies:
build_runner:
build_web_compilers:
pedantic:
build_runner: ^2.4.8
build_web_compilers: ^4.0.9
2 changes: 2 additions & 0 deletions lib/epubrs.dart
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
library epubrs;

import 'dart:convert';
// ignore: unused_import
import 'dart:typed_data';

import 'package:archive/archive.dart';
import 'package:collection/collection.dart' show IterableExtension;
Expand Down
2 changes: 1 addition & 1 deletion lib/epubrs_io.dart
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import 'package:quiver/collection.dart' show listsEqual;
import 'package:xml/xml.dart' as xml;
import 'package:xml/xpath.dart' as xml;

part 'src/model.dart';
part "src/model.dart";
part 'src/reader.dart';
part 'src/writer.dart';

Expand Down
14 changes: 7 additions & 7 deletions pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,15 +7,15 @@ environment:
sdk: '>=3.0.0 <4.0.0'

dependencies:
archive: ^3.1.6
collection: ^1.15.0
archive: ^3.4.10
collection: ^1.18.0
fpdart: ^1.1.0
image: ^4.1.7
path: ^1.8.1
quiver: ^3.0.1+1
xml: ^6.0.1
path: ^1.9.0
quiver: ^3.2.1
xml: ^6.5.0


dev_dependencies:
test: ^1.16.7
pedantic: ^1.11.0
test: ^1.25.2
lints: ^3.0.0
4 changes: 2 additions & 2 deletions test/xml_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,8 @@ void main() {
);
expect(
out.buildDocument().toXmlString(pretty: true), '''<?xml version="1.0"?>
<package xmlns="http://www.idpf.org/2007/opf" version="3.0"\>
<metadata xmlns:dc="http://purl.org/dc/elements/1.1/"\>
<package xmlns="http://www.idpf.org/2007/opf" version="3.0">
<metadata xmlns:dc="http://purl.org/dc/elements/1.1/">
<dc:title>hello</dc:title>
</metadata>
<manifest/>
Expand Down

0 comments on commit b2323ea

Please sign in to comment.