fix(android): fix JS error when RN version is a github URL

__tests__/__snapshots__/android-kotlin.js.snap

@@ -95,6 +95,62 @@ class TestModuleModule(reactContext: ReactApplicationContext) : ReactContextBase
 "
 `;
 
+exports[`Android/Kotlin: Combined creates a TemplateModule.kt with github RN version 1`] = `
+"//  Created by react-native-create-bridge
+
+package com.testapp.testmodule
+
+import com.facebook.react.bridge.ReactApplicationContext
+import com.facebook.react.bridge.ReactContextBaseJavaModule
+import com.facebook.react.bridge.ReactMethod
+import com.facebook.react.bridge.WritableMap
+import com.facebook.react.modules.core.DeviceEventManagerModule
+
+import java.util.Map
+
+class TestModuleModule(reactContext: ReactApplicationContext) : ReactContextBaseJavaModule(reactContext) {
+
+    init {
+        // Here we're saving the context we passed into the constructor to a variable so we can emit events
+        // https://facebook.github.io/react-native/docs/native-modules-android.html#the-toast-module
+        reactContext = context
+    }
+
+    override fun getName(): String {
+        // Tell React the name of the module
+        // https://facebook.github.io/react-native/docs/native-components-android.html#1-create-the-viewmanager-subclass
+        return REACT_CLASS
+    }
+
+    override fun getConstants(): Map<String, Any>? {
+        // Export any constants to be used in your native module
+        // https://facebook.github.io/react-native/docs/native-modules-android.html#the-toast-module
+        val reactConstants = Map<String, Any>()
+        constants.put(\\"EXAMPLE_CONSTANT\\", \\"example\\")
+
+        return constants
+    }
+
+    @ReactMethod
+    fun exampleMethod () {
+        // An example native method that you will expose to React
+        // https://facebook.github.io/react-native/docs/native-modules-android.html#the-toast-module
+    }
+
+    companion object {
+        val REACT_CLASS = \\"TestModule\\"
+        private var reactContext: ReactApplicationContext = null
+
+        private fun emitDeviceEvent(eventName: String, eventData: WritableMap?) {
+            // A method for emitting from the native side to JS
+            // https://facebook.github.io/react-native/docs/native-modules-android.html#sending-events-to-javascript
+            reactContext.getJSModule(DeviceEventManagerModule.RCTDeviceEventEmitter::class.java).emit(eventName, eventData)
+        }
+    }
+}
+"
+`;
+
 exports[`Android/Kotlin: Combined creates a TemplatePackage.kt 1`] = `
 "//  Created by react-native-create-bridge
 

__tests__/android-kotlin.js

@@ -75,6 +75,12 @@ describe('Android/Kotlin: Combined', () => {
     app: 'testapp',
     rnVersion: '0.47.2',
   };
+  const githubConfig = {
+    templateName,
+    packageName: templateName.toLowerCase(),
+    app: 'testapp',
+    rnVersion: 'https://github.com/facebook/react-native#master',
+  };
 
   it('creates a TemplateManager.kt', async () => {
     const fileData = await readFile('TemplateManager.kt', readDirPath);
@@ -93,4 +99,10 @@ describe('Android/Kotlin: Combined', () => {
     const parsedFile = parseFile(fileData, config);
     expect(parsedFile).toMatchSnapshot();
   });
+
+  it('creates a TemplateModule.kt with github RN version', async () => {
+    const fileData = await readFile('TemplateModule.kt', readDirPath);
+    const parsedFile = parseFile(fileData, githubConfig);
+    expect(parsedFile).toMatchSnapshot();
+  });
 });

package.json

@@ -38,6 +38,7 @@
     "compare-versions": "^3.0.1",
     "inquirer": "^2.0.0",
     "is-valid-path": "^0.1.1",
+    "jest-cli": "^21.2.1",
     "log-symbols": "^1.0.2",
     "mkdirp-promise": "^5.0.0",
     "mz": "^2.6.0"

src/file-operations.js

@@ -4,6 +4,19 @@ const compareVersions = require("compare-versions");
 
 const pkg = require(path.join(process.cwd(), "package.json"));
 
+// compare-versions module doesn't export the validate() function, and we need it, so it's copied here
+
+var semver = /^v?(?:\d+)(\.(?:[x*]|\d+)(\.(?:[x*]|\d+)(?:-[\da-z\-]+(?:\.[\da-z\-]+)*)?(?:\+[\da-z\-]+(?:\.[\da-z\-]+)*)?)?)?$/i;
+
+function validate(version) {
+  if (typeof version !== "string") {
+    throw new TypeError("Invalid argument expected string");
+  }
+  if (!semver.test(version)) {
+    throw new Error("Invalid argument not valid semver");
+  }
+}
+
 function getFileNames(dirPath) {
   return fs.readdir(dirPath).catch(e => console.error("[getFileNames] ", e));
 }
@@ -17,9 +30,14 @@ function readFile(file, readDirPath) {
 function parseFile(fileData, { templateName, packageName, app, rnVersion }) {
   let kotlinPackage;
   let javaPackage;
-
+  var version = rnVersion;
+  try {
+    validate(version);
+  } catch (e) {
+    version = null;
+  }
   // TODO: figure out a better way to handle one off breaking changes
-  if (rnVersion && compareVersions(rnVersion, "0.47.2") < 0) {
+  if (version && compareVersions(version, "0.47.2") < 0) {
     kotlinPackage = `
     override fun createJSModules(): List<Class<out JavaScriptModule>> {
         return emptyList()

src/index.js

@@ -56,9 +56,10 @@ function init() {
     .then(result => {
       const { environment, bridgeType, templateName, jsPath } = result;
 
-      const templateFolder = bridgeType.length > 1
-        ? "combined"
-        : bridgeType[0] === "Native Module" ? "modules" : "ui-components";
+      const templateFolder =
+        bridgeType.length > 1
+          ? "combined"
+          : bridgeType[0] === "Native Module" ? "modules" : "ui-components";
 
       const promises = environment.map(env =>
         environmentMap[env](templateName, templateFolder)