Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update abbreviation, abrv, shortcode #398

Closed
missinglink opened this issue Sep 18, 2018 · 2 comments
Closed

Update abbreviation, abrv, shortcode #398

missinglink opened this issue Sep 18, 2018 · 2 comments

Comments

@missinglink
Copy link
Member

Ticket to check the impact of property changes in WOF outlined in:
whosonfirst/whosonfirst-properties#78
@orangejulius
Copy link
Member

We should be able to modify #375 fairly easily to handle any changes

@nvkelso
Copy link

nvkelso commented Sep 18, 2018

See also: pelias/pelias#601.

orangejulius pushed a commit that referenced this issue Sep 19, 2018
@dianashk @orangejulius
feat(abbreviations): handle changing abbreviation fields
110fc5c 
Several abbreviation fields have changed or will change over time in
WOF.

1.) `wof:shortcode` just replaced `wof:abbreviation`
2.) for dependency records, `wof:shortcode` will replace `wof:country`

This change allows us to handle both of those changing fields in a
backwrds compatible way, by supporting the older field but prioritizing
the newer ones.

We should later come in and remove the logic to refer to the older
values once we're sure they're no longer used and enough time has passed
that most people will have updated their copy of WOF data.

Supersedes #273
Supersedes #375
Fixes #398
Fixes pelias/pelias#645
Connects whosonfirst/whosonfirst-properties#78
orangejulius pushed a commit that referenced this issue Sep 19, 2018
@dianashk @orangejulius
feat(abbreviations): handle changing abbreviation fields
90a5007 
Several abbreviation fields have changed or will change over time in
WOF.

1.) `wof:shortcode` just replaced `wof:abbreviation`
2.) for dependency records, `wof:shortcode` will replace `wof:country`

This change allows us to handle both of those changing fields in a
backwards compatible way, by supporting the older field but prioritizing
the newer ones.

We should later come in and remove the logic to refer to the older
values once we're sure they're no longer used and enough time has passed
that most people will have updated their copy of WOF data.

Supersedes #273
Supersedes #375
Fixes #398
Fixes pelias/pelias#645
Connects whosonfirst/whosonfirst-properties#78
orangejulius added a commit that referenced this issue Sep 19, 2018
@orangejulius
feat(abbreviations): handle changing abbreviation fields
ad252d6 
Several abbreviation fields have changed or will change over time in
WOF.

1.) `wof:shortcode` just replaced `wof:abbreviation`
2.) for dependency records, `wof:shortcode` will replace `wof:country`

This change allows us to handle both of those changing fields in a
backwards compatible way, by supporting the older field but prioritizing
the newer ones.

We should later come in and remove the logic to refer to the older
values once we're sure they're no longer used and enough time has passed
that most people will have updated their copy of WOF data.

Supersedes #273
Supersedes #375
Fixes #398
Fixes pelias/pelias#645
Connects whosonfirst/whosonfirst-properties#78
@orangejulius orangejulius mentioned this issue Sep 19, 2018
Merged
orangejulius added a commit to pelias/wof-admin-lookup that referenced this issue Sep 19, 2018
@orangejulius
feat(abbreviation): use wof:shortcode if available
19128b7 
The `wof:shortcode` properly is coming to replace the `wof:abbreviation`
field.

This PR allows either field to work, with `wof:shortcode` preferred, to
account for people who have not yet updated their data.

Connects pelias/whosonfirst#398
Connects pelias/pelias#645
Connects whosonfirst/whosonfirst-properties#78
orangejulius added a commit to pelias/wof-admin-lookup that referenced this issue Sep 19, 2018
@orangejulius
feat(abbreviation): use wof:shortcode if available
6aa90a7 
The `wof:shortcode` properly is coming to replace the `wof:abbreviation`
field.

This PR allows either field to work, with `wof:shortcode` preferred, to
account for people who have not yet updated their data.

Connects pelias/whosonfirst#398
Connects pelias/pelias#645
Connects whosonfirst/whosonfirst-properties#78
orangejulius added a commit to pelias/wof-admin-lookup that referenced this issue Sep 19, 2018
@orangejulius
feat(abbreviation): use wof:shortcode if available
26cf5ea 
The `wof:shortcode` properly is coming to replace the `wof:abbreviation`
field.

This PR allows either field to work, with `wof:shortcode` preferred, to
account for people who have not yet updated their data.

Connects pelias/whosonfirst#398
Connects pelias/pelias#645
Connects whosonfirst/whosonfirst-properties#78
Connects pelias/whosonfirst#399
@orangejulius orangejulius mentioned this issue Sep 19, 2018
Merged
orangejulius added a commit to pelias/wof-admin-lookup that referenced this issue Sep 20, 2018
@orangejulius
feat(abbreviation): use wof:shortcode if available
99aba25 
The `wof:shortcode` properly is coming to replace the `wof:abbreviation`
field.

This PR allows either field to work, with `wof:shortcode` preferred, to
account for people who have not yet updated their data.

Connects pelias/whosonfirst#398
Connects pelias/pelias#645
Connects whosonfirst/whosonfirst-properties#78
Connects pelias/whosonfirst#399
@orangejulius orangejulius mentioned this issue Sep 20, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@orangejulius @missinglink @nvkelso