feat(abbreviation): use wof:shortcode if available #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `wof:shortcode` properly is coming to replace the `wof:abbreviation` field. This PR allows either field to work, with `wof:shortcode` preferred, to account for people who have not yet updated their data. Connects pelias/whosonfirst#398 Connects pelias/pelias#645 Connects whosonfirst/whosonfirst-properties#78 Connects pelias/whosonfirst#399
|
This has been tested on the OpenStreetMap and OpenAddresses importers and appears to correctly use the new |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
wof:shortcodeproperly is coming to replace thewof:abbreviationfield.This PR allows either field to work, with
wof:shortcodepreferred, to account for people who have not yet updated their data.Connects pelias/whosonfirst#398
Connects pelias/pelias#645
Connects whosonfirst/whosonfirst-properties#78
Connects pelias/whosonfirst#399