Add Oauth frontend and backend improvements #718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Boy132
changed the title
lancepioch
requested changes
Nov 20, 2024
Comment on lines
+65
to
+66
| foreach (config('auth.oauth') as $name => $data) { | ||
| config()->set("services.$name", array_merge($data['service'], ['redirect' => "/auth/oauth/callback/$name"])); |
There was a problem hiding this comment.
In the docker container we should probably cache the config on run, want to do that here or can we make an issue for that?
There was a problem hiding this comment.
Not sure what you mean by that?
lancepioch
approved these changes
Nov 30, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds oauth buttons to the filament auth.
Improves the backend and makes adding providers easier.
Adds more default providers.
No oauth for the old auth/ old client area auth! So only admins can use oauth for now!
Note: There is no "automatic registration" when using oauth. If you login via oauth but there is no linked user found, you will be redirected to the login page!