Code

Pedantic linting#1679

Code

Open

van-sprundel wants to merge 45 commits intopendulum-project:mainpendulum-project/ntpd-rs:mainfrom van-sprundel:pedantic-lintvan-sprundel/ntpd-rs:pedantic-lintCopy head branch name to clipboard

+1,413-1,056

Commits

Commits on Jan 8, 2025

• Add lint config and fixes nts-pool-ke

  Show description for d0327f9
  van-sprundel

  committed
  d0327f9

  Copy full SHA for d0327f9

• Add lint config in ntpd

  van-sprundel

  committed
  0733454

  Copy full SHA for 0733454

• Run clippy fix in ntpd

  van-sprundel

  committed
  13eef4e

  Copy full SHA for 13eef4e

• Fix struct_excessive_bools in ntpd

  Show description for bbb7b6d
  van-sprundel

  committed
  bbb7b6d

  Copy full SHA for bbb7b6d

• Use type name instead of Default

  van-sprundel

  committed
  1105cd6

  Copy full SHA for 1105cd6

• cargo fmt

  van-sprundel

  committed
  ad7078e

  Copy full SHA for ad7078e

• Handle conversion of floats

  Show description for 4932e06
  van-sprundel

  committed
  4932e06

  Copy full SHA for 4932e06

• Move struct & enum that are made mid-function

  van-sprundel

  committed
  a20cb36

  Copy full SHA for a20cb36

• Remove unused Result<_> in function

  van-sprundel

  committed
  6fba450

  Copy full SHA for 6fba450

• Mark unfinished function with unused_self

  Show description for 3c0efba
  van-sprundel

  committed
  3c0efba

  Copy full SHA for 3c0efba

• Use reference and mark funtion as too_many_lines

  Show description for e7a3906
  van-sprundel

  committed
  e7a3906

  Copy full SHA for e7a3906

• Use let else instead of if else

  van-sprundel

  committed
  025e03e

  Copy full SHA for 025e03e

• Remove async when not used, split run into functions

  van-sprundel

  committed
  47b8f7d

  Copy full SHA for 47b8f7d

• assert float check should have a limit

  van-sprundel

  committed
  46ea772

  Copy full SHA for 46ea772

• Revert clippy cast_lossless

  Show description for 681fbe8
  van-sprundel

  committed
  681fbe8

  Copy full SHA for 681fbe8

• Allow truncation for darwin target

  van-sprundel

  committed
  5e56bef

  Copy full SHA for 5e56bef

• run cargo fix for ntp-proto

  van-sprundel

  committed
  3160bad

  Copy full SHA for 3160bad

• Mark truncation, wrap, float_cmp and sign loss with #[allow]

  van-sprundel

  committed
  ab7ed1c

  Copy full SHA for ab7ed1c

• Update for loop

  van-sprundel

  committed
  2f94665

  Copy full SHA for 2f94665

• Update references usages

  van-sprundel

  committed
  6df86fe

  Copy full SHA for 6df86fe

• Use specific defaults

  van-sprundel

  committed
  7b6b874

  Copy full SHA for 7b6b874

• Move function result out of Result<> when redundant

  van-sprundel

  committed
  54861e4

  Copy full SHA for 54861e4

• Mark debug impl with finish_non_exhaustive for hidden fields

  van-sprundel

  committed
  e94b01a

  Copy full SHA for e94b01a

• Add should_panic messages

  van-sprundel

  committed
  77115e5

  Copy full SHA for 77115e5

• Add error and panic docs

  van-sprundel

  committed
  c95e170

  Copy full SHA for c95e170

• Update references usage

  van-sprundel

  committed
  17810db

  Copy full SHA for 17810db

• Update formatting

  van-sprundel

  committed
  cf4a964

  Copy full SHA for cf4a964

• Update function to error instead of panic

  van-sprundel

  committed
  f91ec40

  Copy full SHA for f91ec40

• Remove out of else when redundant

  van-sprundel

  committed
  123e854

  Copy full SHA for 123e854

• Use find_map(..) instead of filter_map(..).next()

  van-sprundel

  committed
  f1e1d2c

  Copy full SHA for f1e1d2c

• Split big functions

  van-sprundel

  committed
  a9ff7ba

  Copy full SHA for a9ff7ba

• Use let .. else instead of let if .. else

  van-sprundel

  committed
  8038217

  Copy full SHA for 8038217

• Put v5 imports behind feature flag

  van-sprundel

  committed
  f065a6d

  Copy full SHA for f065a6d

• Fix formatting

  van-sprundel

  committed
  4878655

  Copy full SHA for 4878655

• allow explicit iter loop

  Show description for bbbb15c
  van-sprundel

  committed
  bbbb15c

  Copy full SHA for bbbb15c

• Put nts-pool imports behind feature flag

  van-sprundel

  committed
  710e3f2

  Copy full SHA for 710e3f2

• Fix panic message test

  van-sprundel

  committed
  ff49a8b

  Copy full SHA for ff49a8b

• Remove flag behind mutable variable

  van-sprundel

  committed
  978b528

  Copy full SHA for 978b528

Commits on Jan 9, 2025

• Rebase with main

  van-sprundel

  committed
  8c44e3f

  Copy full SHA for 8c44e3f

• Cleanup

  van-sprundel

  committed
  29db988

  Copy full SHA for 29db988

• Fix build for rustls vers

  van-sprundel

  committed
  1efcbb9

  Copy full SHA for 1efcbb9

• Undo state behind feature

  van-sprundel

  committed
  e75d77e

  Copy full SHA for e75d77e

• Undo changes for ntp_source

  van-sprundel

  committed
  bf8825f

  Copy full SHA for bf8825f

• Remove as_bytes for len check

  van-sprundel

  committed
  e3cdb00

  Copy full SHA for e3cdb00

• Bind lifetime to static instead of inner lifetime

  van-sprundel

  committed
  240d6f8

  Copy full SHA for 240d6f8