switch back to arkworks field arithmetic for 64-bit backend #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redshiftzero
force-pushed
the
arkworks-u64
branch
from
8e1c940 to
eb76dfb
Compare
redshiftzero
changed the title
|
The remaining work here is to figure out why the tests are failing - they are the r1cs feature tests only so likely to be something wrong with Fp |
redshiftzero
force-pushed
the
arkworks-u64
branch
from
eb76dfb to
649ee0f
Compare
TalDerei
approved these changes
Jun 27, 2024
There was a problem hiding this comment.
this looks good, nice work!
will propagate the updated dep versions to penumbra-zone/penumbra#3806 once we cut a release
redshiftzero
force-pushed
the
arkworks-u64
branch
from
649ee0f to
1fd17b7
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #101