Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sorting by decreasing volume #353

Merged
merged 1 commit into from
Feb 5, 2025
Merged

sorting by decreasing volume #353

merged 1 commit into from
Feb 5, 2025

Conversation

TalDerei
Copy link
Contributor

@TalDerei TalDerei commented Feb 5, 2025

follow up from #254, we should instead sort pairs by direct volume rather than liquidity on the explore page


before

Screenshot 2025-02-05 at 11 08 10 AM

after

Screenshot 2025-02-05 at 11 08 41 AM

@TalDerei TalDerei self-assigned this Feb 5, 2025
@TalDerei TalDerei requested review from a team and erwanor February 5, 2025 19:12
@erwanor
Copy link
Member

erwanor commented Feb 5, 2025

Both screenshots are the same unless I am 🥴

@TalDerei
Copy link
Contributor Author

TalDerei commented Feb 5, 2025

Both screenshots are the same unless I am 🥴

first screenshot sorts by decreasing liquidity, second screenshot sorts by decreasing direct volume 🙂

Inspect the respective columns separately and you'll notice they're different

@TalDerei TalDerei merged commit 9083406 into main Feb 5, 2025
3 checks passed
@TalDerei TalDerei deleted the sorting-by-volume branch February 5, 2025 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants