Set Chart to full width #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you provide a screenshot of the change and a description on the PR? 🙏 |
Apologies, added 👍 |
grod220
approved these changes
Sep 18, 2024
| const [chartData, setChartData] = useState< | ||
| [string, number, number, number, number][] | ||
| >([]); // [[date, open, close, low, high]] | ||
| const [chartData, setChartData] = useState<[string, number, number, number, number][]>([]); // [[date, open, close, low, high]] |
There was a problem hiding this comment.
(note for later)
At some point, would be great to convert this data structure to an object versus ordered array.
Comment on lines
+44
to
+52
| const startBlock = await fetch('/api/blocks/1') | ||
| .then(res => res.json()) | ||
| .then(data => { | ||
| const currentBlock = data[0].height; | ||
| console.log(currentBlock); | ||
| const startBlock = | ||
| currentBlock - Math.trunc((daysLookback * 24 * 60 * 60) / blockTimeSeconds); | ||
| console.log('Start block: ', startBlock); | ||
| return startBlock; |
There was a problem hiding this comment.
(note for later)
Would be nice to stick with async/await or then()'s and not mix.
philipjames44
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue that the chart doesnt span the full width: