feat: support PENUMBRA_INDEXER_CA_CERT env var override #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conorsch
requested review from
philipjames44,
JasonMHasperhoven and
cronokirby
|
I deployed a custom build from this tag to https://dex-explorer.testnet.plinfra.net, and confirmed the setting resolved the db connection issues I was experiencing. |
conorsch
force-pushed
the
support-ca-cert-for-db-tls
branch
2 times, most recently
from
b75de80 to
bfa7f28
Compare
conorsch
changed the title
Adds opt-in support for declaring a CA certificate value for the database TLS connection. Some managed postgres solutions, such as DigitalOcean's, require this setting. In order to use it: 1. set the PENUMBRA_INDEXER_CA_CERT env var with the string contents of the db's CA 2. remove the `sslmode=require` from the connection auth string The need for 2 is because the `connectionString` param clobbers any manual `ssl` opts in the db config, and is documented here [0]. Closes #55. [0] https://node-postgres.com/features/ssl#usage-with-connectionstring
conorsch
force-pushed
the
support-ca-cert-for-db-tls
branch
from
bfa7f28 to
e2cff0e
Compare
philipjames44
approved these changes
Sep 20, 2024
conorsch
added a commit
that referenced
this pull request
Sep 25, 2024
Adds a nix config so that tooling like `pnpm` is available immediately. Fleshes out the documentation around connecting to managed database instances, since merge of #56.
conorsch
added a commit
that referenced
this pull request
Sep 25, 2024
Adds a nix config so that tooling like `pnpm` is available immediately. Fleshes out the documentation around connecting to managed database instances, since merge of #56.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds opt-in support for declaring a CA certificate value for the database TLS connection. Some managed postgres solutions, such as DigitalOcean's, require this setting. In order to use it:
sslmode=requirefrom the connection auth stringThe need for 2 is because the
connectionStringparam clobbers any manualsslopts in the db config, and is documented here [0].Closes #55.
[0] https://node-postgres.com/features/ssl#usage-with-connectionstring