Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test coverage #144

Merged
merged 8 commits into from
Mar 26, 2017
Merged

Test coverage #144

merged 8 commits into from
Mar 26, 2017

Conversation

sgoodm
Copy link
Contributor

@sgoodm sgoodm commented Mar 21, 2017 •
edited
Loading

@sgoodm sgoodm mentioned this pull request Mar 21, 2017
Closed
@coveralls
Copy link

Coverage Status

Coverage increased (+1.2%) to 98.99% when pulling d32dcf0 on sgoodm:test_coverage into 64db38a on perrygeo:master.

@perrygeo
Copy link
Owner

perrygeo commented Mar 26, 2017 •
edited
Loading

@sgoodm Thanks for all the work here and in the other PRs. Apologies that I haven't been able to give them adequate review time lately. I plan on trying out this and the nan #146 PR shortly.

The other two new features ( #135 and #136 ) are a bit more involved but I'll try to wrap my head around them in the coming weeks (not months, promise!)

@coveralls
Copy link

Coverage Status

Coverage increased (+1.2%) to 98.998% when pulling 25825a1 on sgoodm:test_coverage into 2a4e4f3 on perrygeo:master.

@perrygeo perrygeo merged commit a0eef4e into perrygeo:master Mar 26, 2017
@sgoodm sgoodm deleted the test_coverage branch March 27, 2017 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sgoodm @coveralls @perrygeo