395 Fix Failing Unit Tests

[NhoxxKienn]

Description

This PR serves to fix the hyperledger-labs#395 issue of failing unit tests.

App Randomizer Internal Test

Location: channel/test/app_randomizer_internal_test.go

Cause: The issue stems from the lack of Comparator (Equal) for MockAppRandomizer. This leads to the test not recognizing that the default appRandomizer has already been set in the internal test.

Solution: Add an identifier to the MockAppRandomizer to compare the old and new appRandomizer.

Dialer Internal Test

Location: (wire/net/simple/dialer_internal_test.go)

Cause: Like @RmbRT has pointed out, there is a race between the init of wire/simple and backend/sim/wire, which set the RandomAddress and RandomAccount functions to be used in the internal tests.

Solution: Add the initialization of NewRandomAddress and NewRandomAccount to use the implementation from the wire/simple.

Alternative: Remove init() of wire/simple and only use the init of backend/sim/wire. This also results in passing internal tests but might cause issues for packages using wire/simple (need further investigation).

[NhoxxKienn]

One other simple alternative to Dialer Internal Test is to remove the address and account generation functions from wiretest in dialer_internal_test.go. This will force the test to use simple Implementations.

Edit: This alternative solution, however, will not pass the current CI's Unit test because The CI currently still uses Go 1.17 which leads to inconsistent inits.