Use go-perun event and timeout types #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…interface from go-perun instead. Accordingly, use RegisteredEvent and ConcludedEvent instead of custom event types. * refactor(channel): Remove timeout.go, as its functionality is now located in the event package. *refactor(event): Remove the Tstamp() method, as it is not used now. Use TimeTimeout type from go-perun instead of custom Timeout type in the Timeout() methods. Remove EventDataFromChannel method because it was only needed for the AdjEvent interface. Use NewTimeTimeout instead of NewTimeout. Rem
… events. * refactor(event) : Remove Timeout() method and Timestamp field in PerunEvent events. Remove custom Timeout methods that are already provided by go-perun * fix(channel): Make AdjEventSub.Next() process PerunEvent events and return AdjudicatorEvent events.
…truct. Introduce DefaultChallengeDuration. Refactor NewTimeTimeout to satisfy TimeoutV field for PerunEvent events. * chore(event): Add doc.go, remove duplicate error check. Refactor MakeTimeout.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the custom Event and Timeout types from the event and channel package to use the types provided by go-perun.