[2.x] Dockerfile Optimization #1014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjsafarali
changed the title
mjsafarali
force-pushed
the
chore/docker-file-optimization
branch
from
567271c to
4f35dbc
Compare
devajmeireles
approved these changes
Dec 15, 2023
owenvoke
reviewed
Dec 16, 2023
| RUN apk update \ | ||
| && apk add zip libzip-dev icu-dev git | ||
| RUN apk update && apk add \ | ||
| zip libzip-dev icu-dev git \ |
There was a problem hiding this comment.
Won't this cause issues as it's a trailing newline?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Description:
Combined apk add commands: Instead of running two separate apk add commands, I combined them into a single command. This saves time and reduces the number of layers in the image.
Combined docker-php-ext-configure, docker-php-ext-install, and docker-php-ext-enable commands: Similarly, I combined these commands for each extension into a single command. This further reduces the number of layers.