GMS-72 Another pack of boring tests

peter-szrnka · Apr 4, 2024 · 634db47 · 634db47
1 parent 84ffd99
commit 634db47
Showing 1 changed file with 12 additions and 4 deletions.
diff --git a/...a/io/github/gms/auth/sso/keycloak/service/impl/KeycloakAuthenticationServiceImplTest.java b/...a/io/github/gms/auth/sso/keycloak/service/impl/KeycloakAuthenticationServiceImplTest.java
@@ -137,25 +137,33 @@ void shouldLoginFail() {
         verify(converter, never()).toUserInfoDto(any(IntrospectResponse.class));
     }
 
-    @Test
-    void shouldLoginFailWhenResponseIsNot2xx() {
+    @ParameterizedTest
+    @MethodSource("not2xxInputData")
+    void shouldLoginFailWhenResponseIsNot2xx(String errorDescription, AuthResponsePhase authResponsePhaseExpected) {
         // arrange
         when(keycloakLoginService.login(DemoData.USERNAME1, DemoData.CREDENTIAL_TEST))
                 .thenReturn(ResponseEntity.status(400).body(LoginResponse.builder()
-                        .error("error").errorDescription("Account disabled").build()));
+                        .error("error").errorDescription(errorDescription).build()));
 
         // act
         AuthenticationResponse response = service.authenticate(DemoData.USERNAME1, DemoData.CREDENTIAL_TEST);
 
         // assert
         assertNotNull(response);
-        assertEquals(AuthResponsePhase.BLOCKED, response.getPhase());
+        assertEquals(authResponsePhaseExpected, response.getPhase());
         verify(keycloakLoginService).login(DemoData.USERNAME1, DemoData.CREDENTIAL_TEST);
         verify(converter, never()).toUserInfoDto(any(IntrospectResponse.class));
         verify(keycloakIntrospectService, never()).getUserDetails(MOCK_ACCESS_TOKEN, MOCK_REFRESH_TOKEN);
         assertLogContains(logAppender, "Login failed! Status code=400");
     }
 
+    private static Object[][] not2xxInputData() {
+        return new Object[][] {
+                { "Account disabled", AuthResponsePhase.BLOCKED },
+                { "Other issue", AuthResponsePhase.FAILED }
+        };
+    }
+
     @Test
     void shouldLoginFailedWhenIntrospectFailed() {
         // arrange