don't create a string when converting from bytes

peteroupc · Jan 15, 2024 · b45ae36 · b45ae36
1 parent 6ed7797
commit b45ae36
Showing 1 changed file with 3 additions and 13 deletions.
diff --git a/CBOR/PeterO/Cbor/CBORUuidConverter.cs b/CBOR/PeterO/Cbor/CBORUuidConverter.cs
@@ -34,19 +34,9 @@ public Guid FromCBORObject(CBORObject obj) {
         throw new CBORException("Must have outermost tag 37");
       }
       _ = ValidateObject(obj);
-      byte[] bytes = obj.GetByteString();
-      var guidChars = new char[36];
-      string hex = "0123456789abcdef";
-      var index = 0;
-      for (int i = 0; i < 16; ++i) {
-        if (i == 4 || i == 6 || i == 8 || i == 10) {
-          guidChars[index++] = '-';
-        }
-        guidChars[index++] = hex[(bytes[i] >> 4) & 15];
-        guidChars[index++] = hex[bytes[i] & 15];
-      }
-      var guidString = new String(guidChars);
-      return new Guid(guidString);
+      byte[] b2 = obj.GetByteString();
+      byte[] bytes = { b2[3], b2[2], b2[1], b2[0], b2[5], b2[4], b2[7], b2[6], b2[8], b2[9], b2[10], b2[11], b2[12], b2[13], b2[14], b2[15] };
+      return new Guid(bytes);
     }
   }
 }