Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Rescoring/Reweighting Bug #693

Merged
merged 4 commits into from
Nov 13, 2023
Merged

Fix Rescoring/Reweighting Bug #693

merged 4 commits into from
Nov 13, 2023

Conversation

Jeff-Thompson12
Copy link
Collaborator

Addresses #680

Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Merging #693 (0e1e6b8) into dev (63854cf) will not change coverage.
Report is 3 commits behind head on dev.
The diff coverage is 100.00%.

❗ Current head 0e1e6b8 differs from pull request most recent head a1dd116. Consider uploading reports for the commit a1dd116 to get more accurate results

@@           Coverage Diff           @@
##              dev     #693   +/-   ##
=======================================
  Coverage   72.98%   72.98%           
=======================================
  Files          33       33           
  Lines        4830     4830           
=======================================
  Hits         3525     3525           
  Misses       1305     1305           
Files Coverage Δ
R/mod_reweightView.R 95.67% <100.00%> (ø)

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@Jeff-Thompson12 Jeff-Thompson12 marked this pull request as ready for review November 8, 2023 15:34
Copy link
Contributor

@Robert-Krajcik Robert-Krajcik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Robert-Krajcik Robert-Krajcik merged commit 659be64 into dev Nov 13, 2023
3 checks passed
@Jeff-Thompson12 Jeff-Thompson12 deleted the jt-680-fix_rescoring_bug branch November 22, 2023 14:32
@AARON-CLARK AARON-CLARK mentioned this pull request Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants