-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ni 581 introjshandling #695
Conversation
Here's a patch that will help you get farther along. The main thing happening here is that when we run the application in a testing environment, we are pulling in internal data elements instead of running the riskmetric code and pulling data from CRAN. Since this is true, a tarball is never downloaded and untarred in the session, which also means that introJS is never displayed in the UI. This patch sets up the environment for the tidyr package. |
Tests passed, pls review the changes |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #695 +/- ##
==========================================
+ Coverage 72.98% 76.97% +3.99%
==========================================
Files 33 33
Lines 4830 4842 +12
==========================================
+ Hits 3525 3727 +202
+ Misses 1305 1115 -190 ☔ View full report in Codecov by Sentry. |
add introjs button for both package explorer and code explorer,make the first element get selected and explanded automatically for package explorer file tree
remove comments, add time
update as per #581
Add tarball extracting code
updated description,namespacing for divs,updated tests
… account for slower machines
b5c09ac
to
f36ce4b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we will probably want to clean up the text supplied to the introJS, but that can be done in another PR.
As per title, tests might be failing, pls have a look