Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ni 581 introjshandling #695

Merged
merged 12 commits into from
Nov 21, 2023
Merged

Ni 581 introjshandling #695

merged 12 commits into from
Nov 21, 2023

Conversation

narayanan-iyer-pfizer
Copy link
Collaborator

As per title, tests might be failing, pls have a look

@Jeff-Thompson12
Copy link
Collaborator

Here's a patch that will help you get farther along.

The main thing happening here is that when we run the application in a testing environment, we are pulling in internal data elements instead of running the riskmetric code and pulling data from CRAN. Since this is true, a tarball is never downloaded and untarred in the session, which also means that introJS is never displayed in the UI. This patch sets up the environment for the tidyr package.

@narayanan-iyer-pfizer
Copy link
Collaborator Author

Tests passed, pls review the changes

Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (30325f8) 72.98% compared to head (0f86be6) 76.97%.
Report is 1 commits behind head on dev.

Files Patch % Lines
R/mod_pkg_explorer.R 80.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #695      +/-   ##
==========================================
+ Coverage   72.98%   76.97%   +3.99%     
==========================================
  Files          33       33              
  Lines        4830     4842      +12     
==========================================
+ Hits         3525     3727     +202     
+ Misses       1305     1115     -190     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

NEWS.md Outdated Show resolved Hide resolved
R/mod_pkg_explorer.R Outdated Show resolved Hide resolved
R/mod_introJS_utils_text.R Outdated Show resolved Hide resolved
R/mod_introJS_utils_text.R Outdated Show resolved Hide resolved
R/mod_introJS_utils_text.R Show resolved Hide resolved
tests/testthat/test-introJS.R Show resolved Hide resolved
DESCRIPTION Show resolved Hide resolved
DESCRIPTION Outdated Show resolved Hide resolved
tests/testthat/test-introJS.R Show resolved Hide resolved
NEWS.md Outdated Show resolved Hide resolved
R/mod_pkg_explorer.R Outdated Show resolved Hide resolved
add introjs button for both package explorer and code explorer,make the first element  get selected and explanded automatically for package explorer file tree
remove comments, add time
update as per #581
Add tarball extracting code
updated description,namespacing for divs,updated tests
Copy link
Collaborator

@Jeff-Thompson12 Jeff-Thompson12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we will probably want to clean up the text supplied to the introJS, but that can be done in another PR.

@Jeff-Thompson12 Jeff-Thompson12 merged commit c977052 into dev Nov 21, 2023
3 checks passed
@Jeff-Thompson12 Jeff-Thompson12 deleted the ni-581-introjshandling branch November 21, 2023 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants