Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix available package list #808

Merged
merged 5 commits into from
Jul 11, 2024
Merged

Fix available package list #808

merged 5 commits into from
Jul 11, 2024

Conversation

jthompson-arcus
Copy link
Collaborator

Closes #776

@jthompson-arcus jthompson-arcus changed the base branch from master to dev July 10, 2024 14:08
Copy link

codecov bot commented Jul 10, 2024

Codecov Report

Attention: Patch coverage is 55.55556% with 4 lines in your changes missing coverage. Please review.

Project coverage is 81.89%. Comparing base (df1813b) to head (67b7852).

Files Patch % Lines
R/app_server.R 55.55% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #808      +/-   ##
==========================================
- Coverage   81.91%   81.89%   -0.03%     
==========================================
  Files          36       36              
  Lines        6692     6698       +6     
==========================================
+ Hits         5482     5485       +3     
- Misses       1210     1213       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jthompson-arcus jthompson-arcus marked this pull request as ready for review July 10, 2024 16:06
@jthompson-arcus
Copy link
Collaborator Author

This PR effectively changes the filters for available.packages() from the list R version, OS type, sub architecture, and duplicates to just duplicates in deployment. This means that R version, OS, and sub architecture where the application is deployed will not impact the list of packages available for upload.

Copy link
Collaborator

@aclark02-arcus aclark02-arcus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 🔥 🔥

@aclark02-arcus aclark02-arcus merged commit ed016fc into dev Jul 11, 2024
1 check passed
@jthompson-arcus jthompson-arcus deleted the jt-776-fix_avaiable_pkg_lst branch July 18, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MASS not available in repo
3 participants