Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more content on the report #14

Merged
merged 9 commits into from
Jan 24, 2025
Merged

Add more content on the report #14

merged 9 commits into from
Jan 24, 2025

Conversation

llrs-roche
Copy link
Collaborator

Most of the data on inst/assessments/dplyr.rds is NA or has an error. This PR adds some more sections based on what it would get.

@llrs-roche llrs-roche marked this pull request as ready for review January 22, 2025 13:34
@llrs-roche
Copy link
Collaborator Author

@Gotfrid @Zhenglei-BCS I reorganized the report and added some more content. Let me know if you like it.
Here is a screenshot of the first sections:
image

I haven't added more content because riskmetrics fails on providing other metrics.

I'll focus on improving the appearance of the report (specially the Installation environment section) on #19 .
This might be only for the html format, as my idea is to provide plots but also hide some long sections.

@Gotfrid Gotfrid self-requested a review January 23, 2025 11:09
Copy link
Contributor

@Gotfrid Gotfrid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks good!

@llrs llrs merged commit 7dbfa1a into main Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants