Fix IceTipCommitBrowser to have a cleaner initialization of the model…

…s and updated its user.
pharo-vcs · Jan 29, 2025 · 2f44a7e · 2f44a7e
1 parent 1c90af6
commit 2f44a7e
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 11 deletions.
diff --git a/Iceberg-TipUI/IceTipCommitBrowser.class.st b/Iceberg-TipUI/IceTipCommitBrowser.class.st
@@ -104,24 +104,25 @@ IceTipCommitBrowser >> doCollapseSelection [
 
 { #category : 'actions' }
 IceTipCommitBrowser >> doCommit [
-	| selectedItems message isPushing isSaving commitBlock|
 
+	| selectedItems message isPushing isSaving commitBlock |
 	selectedItems := diffPanel selectedItems.
 	message := commentPanel message.
 	isPushing := commentPanel isPushing.
 	isSaving := commentPanel isSaving.
-	
-	commitBlock := [  
+
+	commitBlock := [
 		self
 			doCommit: selectedItems
-			message: message
-			pushing: isPushing
-			saving: isSaving ].
-
-	(IceTipCritiquesBeforeCommitBrowser newApplication: self application model: selectedItems)
-		commitModel: self model;
-		onAccept: commitBlock ;
-		openIfCritiques
+		 	message: message
+		  	pushing: isPushing
+		   	saving: isSaving ].
+
+	(IceTipCritiquesBeforeCommitBrowser
+		 onApplication: self application
+		 model: selectedItems
+		 commitModel: self model
+		 acceptBlock: commitBlock) openIfCritiques
 ]
 
 { #category : 'actions' }

diff --git a/Iceberg-TipUI/IceTipCritiquesBeforeCommitBrowser.class.st b/Iceberg-TipUI/IceTipCritiquesBeforeCommitBrowser.class.st
@@ -32,6 +32,18 @@ IceTipCritiquesBeforeCommitBrowser class >> buildSelectionCommandGroupWith: pres
 
 ]
 
+{ #category : 'commands' }
+IceTipCritiquesBeforeCommitBrowser class >> onApplication: anApplication model: aModel commitModel: aCommitModel acceptBlock: anAcceptBlock [
+
+	^ self basicNew
+		  application: anApplication;
+		  setModelBeforeInitialization: aModel;
+		  commitModel: aCommitModel;
+		  onAccept: anAcceptBlock;
+		  initialize;
+		  yourself
+]
+
 { #category : 'actions' }
 IceTipCritiquesBeforeCommitBrowser >> accept [