Skip to content

Commit

Permalink
Merge pull request #1776 from astares/1775-IceTipTagModeldoesNotUnder…
Browse files Browse the repository at this point in the history
…stand-branchName-when-browsing-tags

1775 ice tip tag model does not understand branch name when browsing tags
  • Loading branch information
guillep authored Jan 18, 2024
2 parents eb8661b + 61007b4 commit 9fedc93
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 7 deletions.
6 changes: 6 additions & 0 deletions Iceberg-TipUI/IceTipEntityModel.class.st
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,12 @@ IceTipEntityModel >> isModelOf: anObject [
^ self entity = anObject
]

{ #category : 'accessing' }
IceTipEntityModel >> name [

^ self entity name
]

{ #category : 'tagging' }
IceTipEntityModel >> newCreateTagAction: aString [
<noCache>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ IceTipResetBranchToThisCommitCommand >> defaultNameFromContext [

| shortId branchName |
shortId := self selectedCommitish ifNotNil: [ :commitish | commitish shortId ] ifNil: [''].
branchName := self selectedBranch ifNotNil: [:branch | branch branchName] ifNil: [ '' ].
branchName := self selectedBranch ifNotNil: [:branch | branch name ] ifNil: [ '' ].

^ 'Reset ', branchName, ' to commit ', shortId
]
Expand Down
6 changes: 0 additions & 6 deletions Iceberg-TipUI/IceTipTagModel.class.st
Original file line number Diff line number Diff line change
Expand Up @@ -36,12 +36,6 @@ IceTipTagModel >> description [
^ self entity name
]

{ #category : 'accessing' }
IceTipTagModel >> name [

^ self entity name
]

{ #category : 'actions' }
IceTipTagModel >> previewCheckout [
"this will open a 'checkout browser' that will allow user to validate the changes before
Expand Down

0 comments on commit 9fedc93

Please sign in to comment.