Merge pull request #1885 from Ducasse/Pharo13

Cleaning Spec
pharo-vcs · Jan 26, 2025 · a38b9e6 · a38b9e6
2 parents fe9d746 + 11fe7b5
commit a38b9e6
Show file tree

Hide file tree

Showing 57 changed files with 291 additions and 336 deletions.
diff --git a/Iceberg-Plugin-GitHub/IceGitHubAcceptPullRequestPresenter.class.st b/Iceberg-Plugin-GitHub/IceGitHubAcceptPullRequestPresenter.class.st
@@ -123,12 +123,6 @@ IceGitHubAcceptPullRequestPresenter >> onAccept: aBlock [
 	acceptBlock := aBlock
 ]
 
-{ #category : 'specs' }
-IceGitHubAcceptPullRequestPresenter >> titleForWindow [
-
-	^ 'Accept pull request'
-]
-
 { #category : 'accessing' }
 IceGitHubAcceptPullRequestPresenter >> type [
 
@@ -146,3 +140,9 @@ IceGitHubAcceptPullRequestPresenter >> typeList [
 
 	^ typeList
 ]
+
+{ #category : 'specs' }
+IceGitHubAcceptPullRequestPresenter >> windowTitle [
+
+	^ 'Accept pull request'
+]
diff --git a/Iceberg-Plugin-GitHub/IceGitHubCreatePullRequestPresenter.class.st b/Iceberg-Plugin-GitHub/IceGitHubCreatePullRequestPresenter.class.st
@@ -406,12 +406,6 @@ IceGitHubCreatePullRequestPresenter >> requestGitRepositoryInfo [
 		  getRepository: remote owner project: remote projectBasename
 ]
 
-{ #category : 'specs' }
-IceGitHubCreatePullRequestPresenter >> titleForWindow [
-
-	^ 'New pull request'
-]
-
 { #category : 'accessing - ui' }
 IceGitHubCreatePullRequestPresenter >> titleLabel [
 
@@ -445,3 +439,9 @@ IceGitHubCreatePullRequestPresenter >> updatePresenter [
 	titleTextInput text: self proposedTitle.
 	bodyText text: self proposedComment
 ]
+
+{ #category : 'specs' }
+IceGitHubCreatePullRequestPresenter >> windowTitle [
+
+	^ 'New pull request'
+]
diff --git a/Iceberg-Plugin-GitHub/IceGitHubNewBranchFromIssuePanel.class.st b/Iceberg-Plugin-GitHub/IceGitHubNewBranchFromIssuePanel.class.st
@@ -146,12 +146,6 @@ IceGitHubNewBranchFromIssuePanel >> selectRemoteModel [
 			on: self model entity ]
 ]
 
-{ #category : 'initialization' }
-IceGitHubNewBranchFromIssuePanel >> titleForWindow [
-
-	^ 'New branch from issue'
-]
-
 { #category : 'accessing' }
 IceGitHubNewBranchFromIssuePanel >> unknownTitle [
 
@@ -224,3 +218,9 @@ IceGitHubNewBranchFromIssuePanel >> wait: time thenDo: aBlock [
 			aBlock value ] 
 		forkNamed: 'GitHub issue tracker'
 ]
+
+{ #category : 'initialization' }
+IceGitHubNewBranchFromIssuePanel >> windowTitle [
+
+	^ 'New branch from issue'
+]
diff --git a/Iceberg-Plugin-GitHub/IceGitHubRejectPullRequestPresenter.class.st b/Iceberg-Plugin-GitHub/IceGitHubRejectPullRequestPresenter.class.st
@@ -124,7 +124,7 @@ IceGitHubRejectPullRequestPresenter >> onAccept: aBlock [
 ]
 
 { #category : 'specs' }
-IceGitHubRejectPullRequestPresenter >> titleForWindow [
+IceGitHubRejectPullRequestPresenter >> windowTitle [
 
 	^ 'Reject pull request'
 ]
diff --git a/Iceberg-Plugin-GitHub/IceGitHubRemoveBranchesPresenter.class.st b/Iceberg-Plugin-GitHub/IceGitHubRemoveBranchesPresenter.class.st
@@ -124,16 +124,16 @@ IceGitHubRemoveBranchesPresenter >> timeSinceLastCommit: branch [
 		^ '{1} days' format: {(Date today - lastCommitDate) days}
 ]
 
-{ #category : 'initialization' }
-IceGitHubRemoveBranchesPresenter >> titleForWindow [
-
-	^ 'Select branches to remove on remote {1}' format:
-		  { self remote name }
-]
-
 { #category : 'private' }
 IceGitHubRemoveBranchesPresenter >> triggerAcceptAction [
 
 	acceptBlock ifNil: [ ^ self ].
 	acceptBlock value: selectedItems
 ]
+
+{ #category : 'initialization' }
+IceGitHubRemoveBranchesPresenter >> windowTitle [
+
+	^ 'Select branches to remove on remote {1}' format:
+		  { self remote name }
+]
diff --git a/Iceberg-Plugin-GitHub/IceGitHubTipPullRequestBrowser.class.st b/Iceberg-Plugin-GitHub/IceGitHubTipPullRequestBrowser.class.st
@@ -285,15 +285,15 @@ IceGitHubTipPullRequestBrowser >> setModelBeforeInitialization: aModel [
 	self repositoryModel: aModel
 ]
 
-{ #category : 'accessing' }
-IceGitHubTipPullRequestBrowser >> titleForWindow [
-
-	^ 'Browsing pull request: #{1} {2}' format: { self pullRequest number. self pullRequest title }
-
-]
-
 { #category : 'initialization' }
 IceGitHubTipPullRequestBrowser >> updatePresenter [
 
 	self refresh
 ]
+
+{ #category : 'accessing' }
+IceGitHubTipPullRequestBrowser >> windowTitle [
+
+	^ 'Browsing pull request: #{1} {2}' format: { self pullRequest number. self pullRequest title }
+
+]
diff --git a/Iceberg-Plugin-GitHub/IceTipGitHubPullRequestListBrowser.class.st b/Iceberg-Plugin-GitHub/IceTipGitHubPullRequestListBrowser.class.st
@@ -187,12 +187,6 @@ IceTipGitHubPullRequestListBrowser >> strongSelection: aSelection [
 	self viewPullRequest: aSelection selectedItem
 ]
 
-{ #category : 'initialization' }
-IceTipGitHubPullRequestListBrowser >> titleForWindow [
-
-	^ 'Pull requests on {1} ({2})' format: { self remote name. self remote url }
-]
-
 { #category : 'private' }
 IceTipGitHubPullRequestListBrowser >> updateSelectedPullRequest: aSpSingleSelectionMode [
 
@@ -215,3 +209,9 @@ IceTipGitHubPullRequestListBrowser >> viewPullRequest: aPullRequest [
 					pullRequest: aPullRequest) 
 				open ]
 ]
+
+{ #category : 'initialization' }
+IceTipGitHubPullRequestListBrowser >> windowTitle [
+
+	^ 'Pull requests on {1} ({2})' format: { self remote name. self remote url }
+]
diff --git a/Iceberg-Plugin-GitHub/IceTipGitHubRepositoryPanel.class.st b/Iceberg-Plugin-GitHub/IceTipGitHubRepositoryPanel.class.st
@@ -38,12 +38,6 @@ IceTipGitHubRepositoryPanel >> getGitHubRepository [
 			error pass ]
 ]
 
-{ #category : 'initialization' }
-IceTipGitHubRepositoryPanel >> iconForWindow [
-
-	^ (self iconNamed: #github) lighter: 0.50 "just to be sure is visible in all themes"
-]
-
 { #category : 'accessing' }
 IceTipGitHubRepositoryPanel >> newRepository [
 
@@ -73,7 +67,13 @@ IceTipGitHubRepositoryPanel >> providerName [
 ]
 
 { #category : 'initialization' }
-IceTipGitHubRepositoryPanel >> titleForWindow [
+IceTipGitHubRepositoryPanel >> windowIcon [
+
+	^ (self iconNamed: #github) lighter: 0.50 "just to be sure is visible in all themes"
+]
+
+{ #category : 'initialization' }
+IceTipGitHubRepositoryPanel >> windowTitle [
 
 	^ 'Clone from github.com'
 ]
diff --git a/Iceberg-Plugin-Migration/IceTipFiletreeToTonelDialogPresenter.class.st b/Iceberg-Plugin-Migration/IceTipFiletreeToTonelDialogPresenter.class.st
@@ -147,7 +147,7 @@ IceTipFiletreeToTonelDialogPresenter >> setModelBeforeInitialization: anObject [
 ]
 
 { #category : 'initialization' }
-IceTipFiletreeToTonelDialogPresenter >> titleForWindow [
+IceTipFiletreeToTonelDialogPresenter >> windowTitle [
 
 	^ 'Convert sources to tonel'
 ]
diff --git a/Iceberg-Plugin/IceTipBitbucketRepositoryPanel.class.st b/Iceberg-Plugin/IceTipBitbucketRepositoryPanel.class.st
@@ -21,20 +21,20 @@ IceTipBitbucketRepositoryPanel >> configureBuilder: aBuilder [
 	aBuilder beBitbucket
 ]
 
-{ #category : 'initialization' }
-IceTipBitbucketRepositoryPanel >> iconForWindow [
-
-	^ self iconNamed: #bitbucket
-]
-
 { #category : 'accessing' }
 IceTipBitbucketRepositoryPanel >> providerName [
 
 	^ 'Bitbucket'
 ]
 
 { #category : 'initialization' }
-IceTipBitbucketRepositoryPanel >> titleForWindow [
+IceTipBitbucketRepositoryPanel >> windowIcon [
+
+	^ self iconNamed: #bitbucket
+]
+
+{ #category : 'initialization' }
+IceTipBitbucketRepositoryPanel >> windowTitle [
 
 	^ 'Clone from bitbucket.org'
 ]
diff --git a/Iceberg-Plugin/IceTipGitLabRepositoryPanel.class.st b/Iceberg-Plugin/IceTipGitLabRepositoryPanel.class.st
@@ -21,20 +21,20 @@ IceTipGitLabRepositoryPanel >> configureBuilder: aBuilder [
 	aBuilder beGitLab
 ]
 
-{ #category : 'initialization' }
-IceTipGitLabRepositoryPanel >> iconForWindow [
-
-	^ self iconNamed: #gitlab
-]
-
 { #category : 'accessing' }
 IceTipGitLabRepositoryPanel >> providerName [
 
 	^ 'GitLab'
 ]
 
 { #category : 'initialization' }
-IceTipGitLabRepositoryPanel >> titleForWindow [
+IceTipGitLabRepositoryPanel >> windowIcon [
+
+	^ self iconNamed: #gitlab
+]
+
+{ #category : 'initialization' }
+IceTipGitLabRepositoryPanel >> windowTitle [
 
 	^ 'Clone from gitlab.com'
 ]
diff --git a/Iceberg-TipUI/IceTipAddNewPackagesDialogPresenter.class.st b/Iceberg-TipUI/IceTipAddNewPackagesDialogPresenter.class.st
@@ -65,12 +65,6 @@ IceTipAddNewPackagesDialogPresenter >> defaultLayout [
 			yourself
 ]
 
-{ #category : 'initialization' }
-IceTipAddNewPackagesDialogPresenter >> iconForWindow [
-
-	^ self iconNamed: #branch
-]
-
 { #category : 'initialization' }
 IceTipAddNewPackagesDialogPresenter >> initializePackagesList [
 
@@ -140,12 +134,6 @@ IceTipAddNewPackagesDialogPresenter >> setModelBeforeInitialization: somePackage
 	packages := somePackages
 ]
 
-{ #category : 'initialization' }
-IceTipAddNewPackagesDialogPresenter >> titleForWindow [ 
-
-	^ 'Select New Packages to Load'.
-]
-
 { #category : 'initialization' }
 IceTipAddNewPackagesDialogPresenter >> updatePresenter [
 
@@ -159,3 +147,15 @@ IceTipAddNewPackagesDialogPresenter >> validate [
 		assert: self selectedPackage isNotNil
 		description: 'Please select a branch to checkout.'
 ]
+
+{ #category : 'initialization' }
+IceTipAddNewPackagesDialogPresenter >> windowIcon [
+
+	^ self iconNamed: #branch
+]
+
+{ #category : 'initialization' }
+IceTipAddNewPackagesDialogPresenter >> windowTitle [ 
+
+	^ 'Select New Packages to Load'.
+]
diff --git a/Iceberg-TipUI/IceTipAddPackagesDialogPresenter.class.st b/Iceberg-TipUI/IceTipAddPackagesDialogPresenter.class.st
@@ -51,12 +51,6 @@ IceTipAddPackagesDialogPresenter >> defaultLayout [
 		yourself
 ]
 
-{ #category : 'initialization' }
-IceTipAddPackagesDialogPresenter >> iconForWindow [
-
-	^ self iconNamed: #branch
-]
-
 { #category : 'initialization' }
 IceTipAddPackagesDialogPresenter >> initializePackageNameText [
 
@@ -147,12 +141,6 @@ IceTipAddPackagesDialogPresenter >> setModelBeforeInitialization: anObject [
 	model := anObject
 ]
 
-{ #category : 'initialization' }
-IceTipAddPackagesDialogPresenter >> titleForWindow [
-
-	^ 'Add packages'
-]
-
 { #category : 'initialization' }
 IceTipAddPackagesDialogPresenter >> updatePresenter [
 
@@ -166,3 +154,15 @@ IceTipAddPackagesDialogPresenter >> validate [
 		assert: self selectedPackage isNotNil
 		description: 'Please select a branch to checkout.'
 ]
+
+{ #category : 'initialization' }
+IceTipAddPackagesDialogPresenter >> windowIcon [
+
+	^ self iconNamed: #branch
+]
+
+{ #category : 'initialization' }
+IceTipAddPackagesDialogPresenter >> windowTitle [
+
+	^ 'Add packages'
+]
diff --git a/Iceberg-TipUI/IceTipAddPlaintextCredentialsPresenter.class.st b/Iceberg-TipUI/IceTipAddPlaintextCredentialsPresenter.class.st
@@ -61,7 +61,7 @@ IceTipAddPlaintextCredentialsPresenter >> isOkEnabled [
 ]
 
 { #category : 'initialization' }
-IceTipAddPlaintextCredentialsPresenter >> titleForWindow [
+IceTipAddPlaintextCredentialsPresenter >> windowTitle [
 
 	^ 'Add new Plain Text Credential'
 ]
diff --git a/Iceberg-TipUI/IceTipAddRemoteDialogPresenter.class.st b/Iceberg-TipUI/IceTipAddRemoteDialogPresenter.class.st
@@ -116,12 +116,6 @@ IceTipAddRemoteDialogPresenter >> setModelBeforeInitialization: anObject [
 	model := anObject
 ]
 
-{ #category : 'initialization' }
-IceTipAddRemoteDialogPresenter >> titleForWindow [
-
-	^ 'Add remote'
-]
-
 { #category : 'accessing - ui' }
 IceTipAddRemoteDialogPresenter >> urlLabel [
 
@@ -145,3 +139,9 @@ IceTipAddRemoteDialogPresenter >> validate [
 		description: 'You need to specify a remote url.'
 
 ]
+
+{ #category : 'initialization' }
+IceTipAddRemoteDialogPresenter >> windowTitle [
+
+	^ 'Add remote'
+]
diff --git a/Iceberg-TipUI/IceTipAddSSHCredentialsPresenter.class.st b/Iceberg-TipUI/IceTipAddSSHCredentialsPresenter.class.st
@@ -69,7 +69,7 @@ IceTipAddSSHCredentialsPresenter >> newCredentials [
 ]
 
 { #category : 'initialization' }
-IceTipAddSSHCredentialsPresenter >> titleForWindow [
+IceTipAddSSHCredentialsPresenter >> windowTitle [
 
 	^ 'Add SSH credential'
 ]
diff --git a/Iceberg-TipUI/IceTipAddTokenCredentialsPresenter.class.st b/Iceberg-TipUI/IceTipAddTokenCredentialsPresenter.class.st
@@ -99,12 +99,6 @@ IceTipAddTokenCredentialsPresenter >> newCredentials [
 		yourself 
 ]
 
-{ #category : 'initialization' }
-IceTipAddTokenCredentialsPresenter >> titleForWindow [
-
-	^ 'Add token credentials'
-]
-
 { #category : 'accessing' }
 IceTipAddTokenCredentialsPresenter >> tokenFromInput [
 
@@ -116,3 +110,9 @@ IceTipAddTokenCredentialsPresenter >> usernameFromInput [
 
 	^ usernameInput text
 ]
+
+{ #category : 'initialization' }
+IceTipAddTokenCredentialsPresenter >> windowTitle [
+
+	^ 'Add token credentials'
+]
diff --git a/Iceberg-TipUI/IceTipAskForPlaintextCredentialsPresenter.class.st b/Iceberg-TipUI/IceTipAskForPlaintextCredentialsPresenter.class.st
@@ -52,7 +52,7 @@ IceTipAskForPlaintextCredentialsPresenter >> defaultLayout [
 ]
 
 { #category : 'initialization' }
-IceTipAskForPlaintextCredentialsPresenter >> titleForWindow [
+IceTipAskForPlaintextCredentialsPresenter >> windowTitle [
 
 	^ 'Please log in to ' , askingHostname
 ]