Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing dead code + fix critique logic #1887

Closed
wants to merge 0 commits into from
Closed

Removing dead code + fix critique logic #1887

wants to merge 0 commits into from

Conversation

Ducasse
Copy link
Collaborator

@Ducasse Ducasse commented Jan 28, 2025

Cleaning IceTipCritiquesBeforeCommitBrowser logic.

@Ducasse
Copy link
Collaborator Author

Ducasse commented Jan 28, 2025

I need help @tesonep @jecisc because I do not get why the build is suddenly failing that much.
I fixed a DNU due to the fact that the model of the critique was set after the instance creation.
May be the tests are not in sync with the code of iceberg after my changes.

@Ducasse
Copy link
Collaborator Author

Ducasse commented Jan 29, 2025

Since the PR of seb fixed the problem. I close this one and I will harvest the changes.

@Ducasse Ducasse closed this Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Ducasse