handle when divisor b is zero in all division methods in Division.Java #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
after reviewing the code, each method in Division.java has a new if statement to throw an illegal argument error if the divisor b is zero. |
UmForgotMyName
commented
Nov 1, 2024
| @@ -3,11 +3,17 @@ | |||
| public class Division { | |||
|
|
|||
| public static final long division(int a, int b) { | |||
| if (b == 0) { | |||
There was a problem hiding this comment.
catches if divisor b is 0
UmForgotMyName
commented
Nov 1, 2024
| long result = ((long) a) / ((long) b); | ||
| return result; | ||
| } | ||
|
|
||
| public static final long divisionUsingLoop(int a, int b) { | ||
| if (b == 0) { |
There was a problem hiding this comment.
catches if divisor b is 0
UmForgotMyName
commented
Nov 1, 2024
| @@ -22,6 +28,9 @@ public static final long divisionUsingLoop(int a, int b) { | |||
| } | |||
|
|
|||
| public static final long divisionUsingRecursion(int a, int b) { | |||
| if (b == 0) { | |||
There was a problem hiding this comment.
catches if divisor b is 0
UmForgotMyName
commented
Nov 1, 2024
| @@ -38,6 +47,9 @@ public static final long divisionUsingRecursion(int a, int b) { | |||
| } | |||
|
|
|||
| public static final long divisionUsingMultiplication(int a, int b) { | |||
| if (b == 0) { | |||
There was a problem hiding this comment.
catches if divisor b is 0
UmForgotMyName
commented
Nov 1, 2024
| @@ -55,6 +67,9 @@ public static final long divisionUsingMultiplication(int a, int b) { | |||
| } | |||
|
|
|||
| public static final long divisionUsingShift(int a, int b) { | |||
| if (b == 0) { | |||
There was a problem hiding this comment.
catches if divisor b is 0
UmForgotMyName
commented
Nov 1, 2024
| @@ -76,6 +91,9 @@ public static final long divisionUsingShift(int a, int b) { | |||
| } | |||
|
|
|||
| public static final long divisionUsingLogs(int a, int b) { | |||
| if (b == 0) { | |||
There was a problem hiding this comment.
catches if divisor b is 0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies all methods in Division.java to handle when the divisor, b is zero. This prevents potential runtime errors and improves the robustness of the code.