-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zero Divisor Handling Added #250
base: master
Are you sure you want to change the base?
Conversation
@@ -3,11 +3,21 @@ | |||
public class Division { | |||
|
|||
public static final long division(int a, int b) { | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checking if b=0
@@ -14,4 +14,15 @@ | |||
<natures> | |||
<nature>org.eclipse.jdt.core.javanature</nature> | |||
</natures> | |||
<filteredResources> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
VSCode syntax just changed the spaces here. Not part of the actual change made in this pull request.
long result = ((long) a) / ((long) b); | ||
return result; | ||
} | ||
|
||
public static final long divisionUsingLoop(int a, int b) { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checking if b=0
@@ -22,6 +32,11 @@ public static final long divisionUsingLoop(int a, int b) { | |||
} | |||
|
|||
public static final long divisionUsingRecursion(int a, int b) { | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checking if b=0
@@ -38,6 +53,11 @@ public static final long divisionUsingRecursion(int a, int b) { | |||
} | |||
|
|||
public static final long divisionUsingMultiplication(int a, int b) { | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checking if b=0
@@ -55,6 +75,11 @@ public static final long divisionUsingMultiplication(int a, int b) { | |||
} | |||
|
|||
public static final long divisionUsingShift(int a, int b) { | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checking if b=0
@@ -76,6 +101,11 @@ public static final long divisionUsingShift(int a, int b) { | |||
} | |||
|
|||
public static final long divisionUsingLogs(int a, int b) { | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checking if b=0
Dividing numbers with Zero is currently undefined in mathematics. The program had no safeguard measures if the division is done with a zero and added an exception throw, not to crash the program.
By submitting this pull request I confirm I've read and complied with the below requirements.
Added {Algorithm/DS name} [{Language}]
, notUpdate README.md
orAdded new code
.