Replace Firebase with Supabase #567
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcardonag
reviewed
Feb 5, 2025
| const resourceDatabaseName = | ||
| import.meta.env.VITE_DB_NAME || 'resources'; | ||
| const databaseApiKey = | ||
| import.meta.env.VITE_DB_API_KEY || 'eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJzdXBhYmFzZSIsInJlZiI6IndhbnR5Y2Zibnp6b2NzYnRocXpzIiwicm9sZSI6ImFub24iLCJpYXQiOjE3MzcwNDY2OTgsImV4cCI6MjA1MjYyMjY5OH0.yczsMOx3Y-zsWu-GjYEajIb0yw9fYWEIUglmmfM1zCY'; |
There was a problem hiding this comment.
Following up on our standup chat, lets create a sample .env file for developers to use in the future so that we can pivot away from storing the key in this file.
We should also update the README to include how to request access to the developer .env file in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses ticket #563
This PR officially replaces all Firebase functionality from PHLask and instead replaces it with Supabase. The transition was actually quite easy, since the Supabase SDK is quite easy to use!
To check out the data, message me (@vontell) to get access to the project on Supabase. Otherwise, you should be able to pull this branch and see that the behavior is the same as before.
We should keep the Firebase database around for now to verify that things are looking good after testing. After a while, we can officially close down that project :)
Note that the new Supabase account has two database - the
resourcesdatabase, and thecontributorsdatabase.The one question I have for reviewers - I'd like to insert the API key (don't worry this is a public key similar to the Firebase ones we had) as an environment variable rather than plaintext. Before I do that, I wanted to verify where all the places are that I need to set this. I notice we are not consistent with setting the DB URL, for instance.
Note that part of the changes here seem to be formatting from my editor, sorry for that...