add lsb-vsx port (posix test suite) #54

adamdebek · 2022-08-24T09:48:28Z

Description

Add posix test suite port

Motivation and Context

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

How Has This Been Tested?

Already covered by automatic testing.
New test added: (add PR link here).
Tested by hand on: (list targets here).

Checklist:

My change requires a change to the documentation.
I have updated the documentation accordingly.
I have added tests to cover my changes.
All new and existing linter checks and tests passed.
My changes generate no new compilation warnings for any of the targets.

Special treatment

This PR needs additional PRs to work (list the PRs, preferably in merge-order).
I will merge this PR by myself when appropriate.

lsb_vsx/build.sh

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

codespell

lsb_vsx/lsb_vsx-2.0-1-config/patches/01_install.patch

lsb_vsx/lsb_vsx-2.0-1-config/patches/06_config.patch

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

codespell

lsb_vsx/lsb_vsx-2.0-1-config/patches/06_config.patch

damianloew

Nice to have a possibility to start running some POSIX tests using this test suite. I've left rather small suggestions, also please remove the archive files, they will be downloaded during building process. In addition please create README.md with changes needed to be applied on host before building.

lsb_vsx/build.sh

lsb_vsx/lsb_vsx-2.0-1-config/patches/14_globals.patch

lsb_vsx/lsb_vsx-2.0-1-config/patches/15_missing.patch

lsb_vsx/lsb_vsx-2.0-1-config/patches/18_config_sub.patch

lsb_vsx/build.sh

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

codespell

lsb_vsx/lsb_vsx-2.0-1-config/patches/06_config.patch

lsb_vsx/lsb_vsx-2.0-1-config/patches/02_host_config.patch

nalajcie · 2022-09-09T09:36:04Z

not doing a review, just a note - please remove the binary files (downloaded tar.gz's) from the PR.

lsb_vsx/lsb_vsx-2.0-1-config/patches/19_nonposix.patch

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

codespell

lsb_vsx/README.md

lsb_vsx/lsb_vsx-2.0-1-config/patches/01_install.patch

lsb_vsx/lsb_vsx-2.0-1-config/patches/03_host_other_fixes.patch

lsb_vsx/lsb_vsx-2.0-1-config/patches/02_host_config.patch

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

codespell

lsb_vsx/lsb_vsx-2.0-1-config/patches/09_getline.patch|23| filname ==> filename
lsb_vsx/lsb_vsx-2.0-1-config/patches/09_getline.patch|32| descripor ==> descriptor

lsb_vsx/lsb_vsx-2.0-1-config/patches/02_host_config.patch

lsb_vsx/lsb_vsx-2.0-1-config/patches/09_getline.patch

nalajcie · 2022-09-09T15:02:57Z

@adamdebek I've added commit adding ans to .codespell_ignore list for this PR to be readable. Feel free to reuse it.

Please close all irrelevant / resolved comments so we can move forward with this topic.

lsb_vsx/build.sh

damianloew · 2022-09-09T16:13:30Z

lsb_vsx/build.sh

+cd "$PREFIX_LSB_VSX_FILES" && cp bin/* "$PREFIX_LSB_VSX_TMP"/tetbin_host
+cd "$PREFIX_LSB_VSX_FILES" && cp test_sets/BIN/* "$PREFIX_LSB_VSX_TMP"/BIN_host


I don't see this change, do You want to leave it as it was?

damianloew · 2022-09-09T16:17:17Z

lsb_vsx/lsb_vsx-2.0-1-config/patches/02_host_config.patch

+ fi
+-TET_EXECUTE="$ans"
+
+SPEED="3"


So You don't need to patch this part :)

damianloew · 2022-09-12T09:47:51Z

lsb_vsx/lsb_vsx-2.0-1-config/patches/06_config.patch

+ fi
+-TET_EXECUTE="$ans"
+
+SPEED="3"


I think we can also use the default value here.

lsb_vsx/lsb_vsx-2.0-1-config/patches/07_Makefile.patch

damianloew · 2022-09-12T09:53:08Z

lsb_vsx/lsb_vsx-2.0-1-config/patches/07_Makefile.patch

@@ -0,0 +1,58 @@
+diff -Naur lsb_vsx-2.0-1/test_sets/SRC/install/Makefile.top lsb_vsx-2.0-1-phoenix/test_sets/SRC/install/Makefile.top


I don't see the new patch name

lsb_vsx/lsb_vsx-2.0-1-config/patches/10_mount_spec.patch

lsb_vsx/lsb_vsx-2.0-1-config/patches/13_globals.patch

lsb_vsx/build.sh

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

codespell

lsb_vsx/build.sh

lsb_vsx/lsb_vsx-2.0-1-config/patches/06_config.pasad

lsb_vsx/build.sh

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

codespell

lsb_vsx/lsb_vsx-2.0-1-config/patches/06_config.pasad|474| ans ==> and
lsb_vsx/lsb_vsx-2.0-1-config/patches/06_config.pasad|477| ans ==> and
lsb_vsx/lsb_vsx-2.0-1-config/patches/06_config.pasad|481| ans ==> and
lsb_vsx/lsb_vsx-2.0-1-config/patches/06_config.pasad|495| ans ==> and
lsb_vsx/lsb_vsx-2.0-1-config/patches/06_config.pasad|497| ans ==> and
lsb_vsx/lsb_vsx-2.0-1-config/patches/06_config.pasad|500| ans ==> and
lsb_vsx/lsb_vsx-2.0-1-config/patches/06_config.pasad|504| ans ==> and

lsb_vsx/lsb_vsx-2.0-1-config/patches/06_config.pasad

lsb_vsx/build.sh

lsb_vsx/lsb_vsx-2.0-1-config/patches/06_getline.patch

lsb_vsx/build.sh

lsb_vsx/config/ps_defines.mk

lsb_vsx/patches/ps_VSX/10_tree.patch

lsb_vsx/patches/ps_VSX/11_Clocal.patch

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

codespell

lsb_vsx/patches/host_VSX/02_config.patch

github-actions · 2024-10-17T19:06:07Z

Unit Test Results

7 958 tests ±0 7 416 ✅ ±0 40m 50s ⏱️ -22s
470 suites ±0 542 💤 ±0
1 files ±0 0 ❌ ±0

Results for commit 5c642c2. ± Comparison against base commit e9cdc7b.

♻️ This comment has been updated with latest results.

lsb_vsx/config/ps_tetexec.cfg

build.sh

lsb_vsx/build.sh

JIRA: CI-138

JIRA: CI-141

github-actions bot reviewed Aug 24, 2022

View reviewed changes

adamdebek force-pushed the adamdebek/lsb_vsx_port branch from 9c190b8 to 1b11ba6 Compare August 26, 2022 13:02

github-actions bot reviewed Aug 26, 2022

View reviewed changes

damianloew previously requested changes Aug 30, 2022

View reviewed changes

adamdebek force-pushed the adamdebek/lsb_vsx_port branch from 1b11ba6 to fc4da4f Compare September 7, 2022 15:54

github-actions bot reviewed Sep 7, 2022

View reviewed changes

lsb_vsx/build.sh Outdated Show resolved Hide resolved

lsb_vsx/build.sh Outdated Show resolved Hide resolved

github-actions bot reviewed Sep 7, 2022

View reviewed changes

nalajcie reviewed Sep 9, 2022

View reviewed changes

lsb_vsx/lsb_vsx-2.0-1-config/patches/19_nonposix.patch Outdated Show resolved Hide resolved

adamdebek force-pushed the adamdebek/lsb_vsx_port branch from fc4da4f to d3be073 Compare September 9, 2022 13:29

github-actions bot reviewed Sep 9, 2022

View reviewed changes

adamdebek force-pushed the adamdebek/lsb_vsx_port branch from d3be073 to 0e8ef88 Compare September 9, 2022 14:12

github-actions bot reviewed Sep 9, 2022

View reviewed changes

lsb_vsx/lsb_vsx-2.0-1-config/patches/09_getline.patch Outdated Show resolved Hide resolved

lsb_vsx/lsb_vsx-2.0-1-config/patches/09_getline.patch Outdated Show resolved Hide resolved

damianloew reviewed Sep 12, 2022

View reviewed changes

nalajcie reviewed Sep 12, 2022

View reviewed changes

lsb_vsx/build.sh Outdated Show resolved Hide resolved

adamdebek force-pushed the adamdebek/lsb_vsx_port branch from 0a0e2d7 to fefe2ae Compare September 21, 2022 10:51

github-actions bot reviewed Sep 21, 2022

View reviewed changes

lsb_vsx/build.sh Outdated Show resolved Hide resolved

lsb_vsx/build.sh Outdated Show resolved Hide resolved

lsb_vsx/build.sh Outdated Show resolved Hide resolved

lsb_vsx/build.sh Outdated Show resolved Hide resolved

lsb_vsx/build.sh Outdated Show resolved Hide resolved

damianloew marked this pull request as draft September 21, 2022 10:57

github-actions bot reviewed Sep 21, 2022

View reviewed changes

github-actions bot reviewed Sep 22, 2022

View reviewed changes

adamdebek force-pushed the adamdebek/lsb_vsx_port branch from 5eb24a5 to bdee1bf Compare September 23, 2022 08:25

github-actions bot reviewed Sep 23, 2022

View reviewed changes

lsb_vsx/lsb_vsx-2.0-1-config/patches/06_getline.patch Outdated Show resolved Hide resolved

lsb_vsx/lsb_vsx-2.0-1-config/patches/06_getline.patch Outdated Show resolved Hide resolved

github-actions bot reviewed Sep 23, 2022

View reviewed changes

lsb_vsx/build.sh Outdated Show resolved Hide resolved

lsb_vsx/build.sh Outdated Show resolved Hide resolved

lsb_vsx/build.sh Outdated Show resolved Hide resolved

lsb_vsx/build.sh Outdated Show resolved Hide resolved

lsb_vsx/build.sh Outdated Show resolved Hide resolved

damianloew requested a review from nalajcie September 23, 2022 08:35

github-actions bot reviewed Oct 17, 2024

View reviewed changes

lsb_vsx/config/ps_defines.mk Show resolved Hide resolved

lsb_vsx/patches/ps_VSX/10_tree.patch Outdated Show resolved Hide resolved

lsb_vsx/patches/ps_VSX/11_Clocal.patch Show resolved Hide resolved

lsb_vsx/patches/ps_VSX/11_Clocal.patch Show resolved Hide resolved

adamdebek force-pushed the adamdebek/lsb_vsx_port branch 3 times, most recently from 814968d to a632afc Compare October 17, 2024 18:32

github-actions bot reviewed Oct 17, 2024

View reviewed changes

adamdebek force-pushed the adamdebek/lsb_vsx_port branch 2 times, most recently from 4caac67 to 2c50ebb Compare October 17, 2024 18:49

adamdebek force-pushed the adamdebek/lsb_vsx_port branch 2 times, most recently from d9f7cd5 to 22c83f6 Compare October 18, 2024 14:26

damianloew self-requested a review October 18, 2024 14:54

adamdebek force-pushed the adamdebek/lsb_vsx_port branch from 22c83f6 to c3e6167 Compare October 29, 2024 13:03

github-actions bot reviewed Oct 29, 2024

View reviewed changes

lsb_vsx/config/ps_tetexec.cfg Outdated Show resolved Hide resolved

adamdebek force-pushed the adamdebek/lsb_vsx_port branch from c3e6167 to 5b5494c Compare October 29, 2024 13:23

adamdebek force-pushed the adamdebek/lsb_vsx_port branch from 5b5494c to dad30de Compare November 6, 2024 18:13

adamdebek force-pushed the adamdebek/lsb_vsx_port branch from dad30de to a6a5ff5 Compare November 27, 2024 18:56

github-actions bot reviewed Nov 27, 2024

View reviewed changes

build.sh Outdated Show resolved Hide resolved

adamdebek force-pushed the adamdebek/lsb_vsx_port branch 2 times, most recently from 6580b8e to c448082 Compare December 3, 2024 15:34

adamdebek force-pushed the adamdebek/lsb_vsx_port branch from c448082 to 047b7f9 Compare January 3, 2025 21:04

github-actions bot reviewed Jan 3, 2025

View reviewed changes

lsb_vsx/build.sh Show resolved Hide resolved

adamdebek force-pushed the adamdebek/lsb_vsx_port branch from 047b7f9 to 213f675 Compare January 8, 2025 13:32

damianloew reviewed Jan 8, 2025

View reviewed changes

lsb_vsx/build.sh Outdated Show resolved Hide resolved

adamdebek added 2 commits January 9, 2025 14:38

add lsb_vsx testsuite

f97bedb

JIRA: CI-138

lsb_vsx: add README.md

5c642c2

JIRA: CI-141

adamdebek force-pushed the adamdebek/lsb_vsx_port branch from 213f675 to 5c642c2 Compare January 9, 2025 13:39

adamdebek requested a review from damianloew January 14, 2025 15:38

damianloew approved these changes Jan 17, 2025

View reviewed changes

damianloew merged commit 1994dc6 into master Jan 17, 2025
36 checks passed

damianloew deleted the adamdebek/lsb_vsx_port branch January 17, 2025 10:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add lsb-vsx port (posix test suite) #54

add lsb-vsx port (posix test suite) #54

adamdebek commented Aug 24, 2022

github-actions bot left a comment

github-actions bot left a comment

damianloew left a comment

github-actions bot left a comment

nalajcie commented Sep 9, 2022

github-actions bot left a comment

github-actions bot left a comment

nalajcie commented Sep 9, 2022

damianloew Sep 9, 2022

damianloew Sep 9, 2022

damianloew Sep 12, 2022

damianloew Sep 12, 2022

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot commented Oct 17, 2024 •

edited

Loading

		cd "$PREFIX_LSB_VSX_FILES" && cp bin/* "$PREFIX_LSB_VSX_TMP"/tetbin_host
		cd "$PREFIX_LSB_VSX_FILES" && cp test_sets/BIN/* "$PREFIX_LSB_VSX_TMP"/BIN_host

		@@ -0,0 +1,58 @@
		diff -Naur lsb_vsx-2.0-1/test_sets/SRC/install/Makefile.top lsb_vsx-2.0-1-phoenix/test_sets/SRC/install/Makefile.top

add lsb-vsx port (posix test suite) #54

add lsb-vsx port (posix test suite) #54

Conversation

adamdebek commented Aug 24, 2022

Description

Motivation and Context

Types of changes

How Has This Been Tested?

Checklist:

Special treatment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

damianloew left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

nalajcie commented Sep 9, 2022

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

nalajcie commented Sep 9, 2022

damianloew Sep 9, 2022

Choose a reason for hiding this comment

damianloew Sep 9, 2022

Choose a reason for hiding this comment

damianloew Sep 12, 2022

Choose a reason for hiding this comment

damianloew Sep 12, 2022

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot commented Oct 17, 2024 • edited Loading

Unit Test Results

github-actions bot commented Oct 17, 2024 •

edited

Loading